Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip attachments from emails when converting #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucaspiller
Copy link
Contributor

Strips attachments from emails when converting to text and PDF. Prevents trying to create 2000 page PDF files 😄

@vjt
Copy link
Contributor

vjt commented Jul 18, 2016

This should be optional, because attachment conversion is a useful feature. One option could be avoid trying to convert too large attachments, e.g. whose byte size exceeds a defined threshold. An even better option would be to quickly parse the PDF to read the number of pages it is composed of, and specify the threshold as a maximum pages count.

@lucaspiller
Copy link
Contributor Author

The previous behaviour was to convert the raw email to PDF, which for one example I had resulted in a 2000 page PDF file - the attachments weren't converted separately.

It took around 60 seconds to perform, so if it's that big I'd prefer not to even attempt conversion.

Note that this just strips them when converting to text or PDF. The email and attachments are still available in the original version.

On 18 Jul 2016, 13:44 +0300, Marcello [email protected], wrote:

This should be optional, because attachment conversion is a useful feature. One option could be avoid trying to convert too large attachments, e.g. whose byte size exceeds a defined threshold. An even better option would be to quickly parse the PDF to read the number of pages it is composed of, and specify the threshold as a maximum pages count.


You are receiving this because you authored the thread.
Reply to this email directly,view it on GitHub(#5 (comment)), ormute the thread(https://github.com/notifications/unsubscribe-auth/AABH5OtCHIwfo5tpX5fpv4dHIBl2yU8kks5qW1jlgaJpZM4JJYyT).

@vjt
Copy link
Contributor

vjt commented Mar 27, 2020

After 4yrs, I am now reconsidering this as a useful feature considering how much inherent junk is there in enterprise emails.

@vjt vjt added the question label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants