Upgrade wazero to v1.8.0 and add Close() method to the Calculator interface #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a method Close to Calculator interface. It calls the Close method on the underlying CalculatorImpl if one is supports optional io.Closer interface.
OBrezhniev
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade wazero module to v1.8.0, that fixes #22 memory leak.
Add a method Close to Calculator interface. It calls the Close method on the underlying CalculatorImpl if one is supports optional io.Closer interface.
Minimum Go version was upgraded to 1.21 for witness/wazero module (as required by latest dependency). I did not change go.mod and brake building on older versions for other modules, but tests run only against 3 latest major versions from 1.21 to 1.23 for all witness modules.