Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deep copy methods for components #620

Merged
merged 4 commits into from
Oct 22, 2024

Commits on Oct 20, 2024

  1. Migrated Ical.Net.Tests rpoject from NUnit3 to NUnit 4

    * Migrate NUnit 3.14.0 to 4.2.2
    * Add NUnit.Analyzers 4.3.0
    * Convert Classic Assert to Constraint Model
    * Introduce Assert.Multiple to group assertions, ensuring all are evaluated even if some fail.
    * Simplify test case source return types to IEnumerable without a type argument
    * Remove unused using directives and added necessary ones.
    
    Test logic is left unchanged except for 7 tests in Exception context.
    Here all try...catch blocks are replaced with `Throws.` assertions.
    axunonb committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    7b39254 View commit details
    Browse the repository at this point in the history
  2. Implement deep copy methods for components

    - Implemented `CopyFrom` method in multiple classes for deep copying.
    - Removed questions in code and implemented solution
    - Updated `ICopyable` interface documentation.
    - Introduced pattern matching for better readability
    - Added new test methods in `CopyComponentTests` class for deep copying various calendar components.
    - Fixed broken SerializationTests.AttendeesSerialized() (Corrected attendee names and fixed typos in assertions.)
    - Refactored `CalendarObjectBase` (should eventually become abstract)
    - Added `ExcludeFromCodeCoverage` attribute to `CalendarObjectList`.
    - Updated `Ical.Net.csproj` to latest C# version.
    
    Fixes ical-org#149
    axunonb committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f309d47 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1a8c88e View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Implement changes from review

    * Removed redundant check in `Attachment.cs` `CopyFrom` method.
    * Updated `Period.cs` and `Trigger.cs` to use `Copy<IDateTime>()` method.
    * Modified `Alarm` class to implement `IComparable<Alarm>` with `CompareTo` method.
    axunonb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    469c767 View commit details
    Browse the repository at this point in the history