Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore timezone if two periods are compared for equality #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbuehlma
Copy link
Contributor

This solves the case where exception dates are ignored due to different time zone than the recurring event.

This PR is a follow up to #307.

On IDateTime there were cases where it was required to honour the timezone in equals.
Therefore, this PR changes the Equals on "Period" which also solves the issue. Are there also cases where the Timezone for a Period is relevant in case of comparing them? I currently cant think of one and therefore think this could be a nice fix for my issue.

What is your opinion on that?

If its ok, I will also update the v2-version and do the package updates.

This solves the case where exception dates are ignored due to different time zone than the recurring event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant