Watch NTP server change in timesyncd #156
Open
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In phosphor-networkd, network-provided NTP servers are updated only at the time of interface creation. Any modifications to the NTP server are not reflected in networkd until the next restart. As of systemd version 255, timesyncd emits a property changed signal when the LinkNTPServers property is updated. This commit implements a watch for the signal from timesyncd, ensuring that phosphor-networkd loads the updated NTP servers dynamically. Also, any change in the dynamic NTP servers when system is in manual mode as the timesyncd is disabled. However the change is not updated even when the system is switched to NTP mode. This commit also consists of the changes to the reload the NTP servers whenever it switches from manual to NTP mode. Tested by: 1. Connected the BMC to a DHCP server 2. Configured the DHCP server with the NTP server IP. 3. Verified that timesyncd is updated with the new NTP server IP. 4. Confirmed that phosphor-networkd receives the signal and updates the D-Bus with the latest NTP servers from timesyncd. 5. Switched to manual mode, updated the NTP servers in DHCP. Verified the updated NTP server is reflected in networkd. Change-Id: I6a58e44795e60490d8bee106548de043be40bfe8 Signed-off-by: Jishnu CM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any change in the dynamic NTP servers when system is in manual mode as the timesyncd is disabled. However the change is not updated even when the system is switched to NTP mode. This commit also consists of the changes to the reload the NTP servers whenever it switches from manual to NTP mode.
Tested by:
Switched to manual mode, updated the NTP servers in DHCP. Verified the updated NTP server is reflected in networkd when switched back to manual.
Fixes : https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=649008
Change-Id: I6a58e44795e60490d8bee106548de043be40bfe8