Add Checkbox question type #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amy-corson-ibigroup
approved these changes
Oct 11, 2024
Comment on lines
+20
to
+26
| <> | ||
| <h1>How many stars are there in the sky?</h1> | ||
| <Checkboxes | ||
| options={['one', 'two', 'three', 'four', 'five']} | ||
| updateCallback={action('Option is selected')} | ||
| /> | ||
| </> |
There was a problem hiding this comment.
Wait is there a reason this is with an h1? I think it should be a fieldset with a legend
|
|
||
| .container label { | ||
| display: grid; | ||
| align-items: baseline; |
There was a problem hiding this comment.
I think this baseline is making the labels look lower than the checkboxes
| baseline | no baseline |
|---|---|
| @@ -0,0 +1,21 @@ | |||
| .container { | |||
| font-size: 25px; | |||
| width: 100%; | |||
There was a problem hiding this comment.
This width is making it so you can click really far away from the checkboxes and accidentally select one?
| @@ -1,7 +1,9 @@ | |||
| { | |||
| "name": "survey", | |||
| "version": "0.1.0", | |||
| "engines": { "node": "18.x" }, | |||
| "engines": { | |||
| "node": ">=18.x" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious for feedback on styling. Tried to optimize for longer answer lengths.