Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Placeholder For Custom Raw Input #1007

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update Placeholder For Custom Raw Input #1007

merged 1 commit into from
Jan 10, 2024

Conversation

philip-cline
Copy link
Contributor

@philip-cline philip-cline commented Jan 4, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Using "blah" was perhaps not the most demonstrative or user-friendly. This PR updates that placeholder to just use "property"

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on this one phil

@daniel-heppner-ibigroup daniel-heppner-ibigroup removed their assignment Jan 8, 2024
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out with a bang

@miles-grant-ibigroup miles-grant-ibigroup merged commit d457b45 into dev Jan 10, 2024
5 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the update-raw-input-language branch January 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philip-cline @miles-grant-ibigroup @daniel-heppner-ibigroup