OLED::printSymbolDeg(): attempt to improve read-ability replacing if/…

…else by switch/case
ia · Jul 17, 2023 · f26b868 · f26b868
1 parent 6104160
commit f26b868
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/source/Core/Drivers/OLED.cpp b/source/Core/Drivers/OLED.cpp
@@ -483,14 +483,17 @@ void OLED::printWholeScreen(const char *string) {
 
 // Print *F or *C - in font style of Small, Large (by default) or Extra based on input arg
 void OLED::printSymbolDeg(const FontStyle fontStyle) {
-  if (FontStyle::EXTRAS == fontStyle) {
+  switch (fontStyle) {
+  case FontStyle::EXTRAS:
     OLED::drawSymbol(getSettingValue(SettingsOptions::TemperatureInF) ? 0 : 1);
-  } else {
-    if (getSettingValue(SettingsOptions::TemperatureInF)) {
-      OLED::print(fontStyle == FontStyle::LARGE ? LargeSymbolDegF : SmallSymbolDegF, fontStyle);
-    } else {
-      OLED::print(fontStyle == FontStyle::LARGE ? LargeSymbolDegC : SmallSymbolDegC, fontStyle);
-    }
+    break;
+  case FontStyle::LARGE:
+    OLED::print(getSettingValue(SettingsOptions::TemperatureInF) ? LargeSymbolDegF : LargeSymbolDegC, fontStyle);
+    break;
+  case FontStyle::SMALL:
+  default:
+    OLED::print(getSettingValue(SettingsOptions::TemperatureInF) ? SmallSymbolDegF : SmallSymbolDegC, fontStyle);
+    break;
   }
 }