Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declutter ros2 service list #119

Open
justinIRBT opened this issue Oct 27, 2021 · 1 comment
Open

Declutter ros2 service list #119

justinIRBT opened this issue Oct 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@justinIRBT
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
On the robot, ros2 service list returns:

$ ros2 service list -t
/e_stop [irobot_create_msgs/srv/EStop]
/motion_control/describe_parameters [rcl_interfaces/srv/DescribeParameters]
/motion_control/get_parameter_types [rcl_interfaces/srv/GetParameterTypes]
/motion_control/get_parameters [rcl_interfaces/srv/GetParameters]
/motion_control/list_parameters [rcl_interfaces/srv/ListParameters]
/motion_control/set_parameters [rcl_interfaces/srv/SetParameters]
/motion_control/set_parameters_atomically [rcl_interfaces/srv/SetParametersAtomically]
/robot_power [irobot_create_msgs/srv/RobotPower]
/static_transform/describe_parameters [rcl_interfaces/srv/DescribeParameters]
/static_transform/get_parameter_types [rcl_interfaces/srv/GetParameterTypes]
/static_transform/get_parameters [rcl_interfaces/srv/GetParameters]
/static_transform/list_parameters [rcl_interfaces/srv/ListParameters]
/static_transform/set_parameters [rcl_interfaces/srv/SetParameters]
/static_transform/set_parameters_atomically [rcl_interfaces/srv/SetParametersAtomically]

On the sim, it returns:

/bump_front_center_plugin/describe_parameters
/bump_front_center_plugin/get_parameter_types
/bump_front_center_plugin/get_parameters
/bump_front_center_plugin/list_parameters
/bump_front_center_plugin/set_parameters
/bump_front_center_plugin/set_parameters_atomically
/cliff_front_left/describe_parameters
/cliff_front_left/get_parameter_types
/cliff_front_left/get_parameters
/cliff_front_left/list_parameters
/cliff_front_left/set_parameters
/cliff_front_left/set_parameters_atomically
/cliff_front_right/describe_parameters
/cliff_front_right/get_parameter_types
/cliff_front_right/get_parameters
/cliff_front_right/list_parameters
/cliff_front_right/set_parameters
/cliff_front_right/set_parameters_atomically
/cliff_side_left/describe_parameters
/cliff_side_left/get_parameter_types
/cliff_side_left/get_parameters
/cliff_side_left/list_parameters
/cliff_side_left/set_parameters
/cliff_side_left/set_parameters_atomically
/cliff_side_right/describe_parameters
/cliff_side_right/get_parameter_types
/cliff_side_right/get_parameters
/cliff_side_right/list_parameters
/cliff_side_right/set_parameters
/cliff_side_right/set_parameters_atomically
/controller_manager/configure_and_start_controller
/controller_manager/configure_controller
/controller_manager/describe_parameters
/controller_manager/get_parameter_types
/controller_manager/get_parameters
/controller_manager/list_controller_types
/controller_manager/list_controllers
/controller_manager/list_hardware_interfaces
/controller_manager/list_parameters
/controller_manager/load_and_configure_controller
/controller_manager/load_and_start_controller
/controller_manager/load_controller
/controller_manager/reload_controller_libraries
/controller_manager/set_parameters
/controller_manager/set_parameters_atomically
/controller_manager/switch_controller
/controller_manager/unload_controller
/delete_entity
/diffdrive_controller/describe_parameters
/diffdrive_controller/get_parameter_types
/diffdrive_controller/get_parameters
/diffdrive_controller/list_parameters
/diffdrive_controller/set_parameters
/diffdrive_controller/set_parameters_atomically
/dock_state_publisher/describe_parameters
/dock_state_publisher/get_parameter_types
/dock_state_publisher/get_parameters
/dock_state_publisher/list_parameters
/dock_state_publisher/set_parameters
/dock_state_publisher/set_parameters_atomically
/dock_status_publisher/describe_parameters
/dock_status_publisher/get_parameter_types
/dock_status_publisher/get_parameters
/dock_status_publisher/list_parameters
/dock_status_publisher/set_parameters
/dock_status_publisher/set_parameters_atomically
/e_stop
/gazebo/describe_parameters
/gazebo/get_parameter_types
/gazebo/get_parameters
/gazebo/list_parameters
/gazebo/set_parameters
/gazebo/set_parameters_atomically
/gazebo_ros2_control/describe_parameters
/gazebo_ros2_control/get_parameter_types
/gazebo_ros2_control/get_parameters
/gazebo_ros2_control/list_parameters
/gazebo_ros2_control/set_parameters
/gazebo_ros2_control/set_parameters_atomically
/gazebo_ros_p3d_dock/describe_parameters
/gazebo_ros_p3d_dock/get_parameter_types
/gazebo_ros_p3d_dock/get_parameters
/gazebo_ros_p3d_dock/list_parameters
/gazebo_ros_p3d_dock/set_parameters
/gazebo_ros_p3d_dock/set_parameters_atomically
/gazebo_ros_p3d_robot/describe_parameters
/gazebo_ros_p3d_robot/get_parameter_types
/gazebo_ros_p3d_robot/get_parameters
/gazebo_ros_p3d_robot/list_parameters
/gazebo_ros_p3d_robot/set_parameters
/gazebo_ros_p3d_robot/set_parameters_atomically
/get_model_list
/hazards_vector_node/describe_parameters
/hazards_vector_node/get_parameter_types
/hazards_vector_node/get_parameters
/hazards_vector_node/list_parameters
/hazards_vector_node/set_parameters
/hazards_vector_node/set_parameters_atomically
/imu_plugin/describe_parameters
/imu_plugin/get_parameter_types
/imu_plugin/get_parameters
/imu_plugin/list_parameters
/imu_plugin/set_parameters
/imu_plugin/set_parameters_atomically
/ir_intensity_front_center_left/describe_parameters
/ir_intensity_front_center_left/get_parameter_types
/ir_intensity_front_center_left/get_parameters
/ir_intensity_front_center_left/list_parameters
/ir_intensity_front_center_left/set_parameters
/ir_intensity_front_center_left/set_parameters_atomically
/ir_intensity_front_center_right/describe_parameters
/ir_intensity_front_center_right/get_parameter_types
/ir_intensity_front_center_right/get_parameters
/ir_intensity_front_center_right/list_parameters
/ir_intensity_front_center_right/set_parameters
/ir_intensity_front_center_right/set_parameters_atomically
/ir_intensity_front_left/describe_parameters
/ir_intensity_front_left/get_parameter_types
/ir_intensity_front_left/get_parameters
/ir_intensity_front_left/list_parameters
/ir_intensity_front_left/set_parameters
/ir_intensity_front_left/set_parameters_atomically
/ir_intensity_front_right/describe_parameters
/ir_intensity_front_right/get_parameter_types
/ir_intensity_front_right/get_parameters
/ir_intensity_front_right/list_parameters
/ir_intensity_front_right/set_parameters
/ir_intensity_front_right/set_parameters_atomically
/ir_intensity_left/describe_parameters
/ir_intensity_left/get_parameter_types
/ir_intensity_left/get_parameters
/ir_intensity_left/list_parameters
/ir_intensity_left/set_parameters
/ir_intensity_left/set_parameters_atomically
/ir_intensity_right/describe_parameters
/ir_intensity_right/get_parameter_types
/ir_intensity_right/get_parameters
/ir_intensity_right/list_parameters
/ir_intensity_right/set_parameters
/ir_intensity_right/set_parameters_atomically
/ir_intensity_side_left/describe_parameters
/ir_intensity_side_left/get_parameter_types
/ir_intensity_side_left/get_parameters
/ir_intensity_side_left/list_parameters
/ir_intensity_side_left/set_parameters
/ir_intensity_side_left/set_parameters_atomically
/ir_intensity_vector_node/describe_parameters
/ir_intensity_vector_node/get_parameter_types
/ir_intensity_vector_node/get_parameters
/ir_intensity_vector_node/list_parameters
/ir_intensity_vector_node/set_parameters
/ir_intensity_vector_node/set_parameters_atomically
/ir_omni_plugin/describe_parameters
/ir_omni_plugin/get_parameter_types
/ir_omni_plugin/get_parameters
/ir_omni_plugin/list_parameters
/ir_omni_plugin/set_parameters
/ir_omni_plugin/set_parameters_atomically
/joint_state_broadcaster/describe_parameters
/joint_state_broadcaster/get_parameter_types
/joint_state_broadcaster/get_parameters
/joint_state_broadcaster/list_parameters
/joint_state_broadcaster/set_parameters
/joint_state_broadcaster/set_parameters_atomically
/joint_state_publisher/describe_parameters
/joint_state_publisher/get_parameter_types
/joint_state_publisher/get_parameters
/joint_state_publisher/list_parameters
/joint_state_publisher/set_parameters
/joint_state_publisher/set_parameters_atomically
/mock_publisher_node/describe_parameters
/mock_publisher_node/get_parameter_types
/mock_publisher_node/get_parameters
/mock_publisher_node/list_parameters
/mock_publisher_node/set_parameters
/mock_publisher_node/set_parameters_atomically
/motion_control/describe_parameters
/motion_control/get_parameter_types
/motion_control/get_parameters
/motion_control/list_parameters
/motion_control/set_parameters
/motion_control/set_parameters_atomically
/mouse_plugin/describe_parameters
/mouse_plugin/get_parameter_types
/mouse_plugin/get_parameters
/mouse_plugin/list_parameters
/mouse_plugin/set_parameters
/mouse_plugin/set_parameters_atomically
/pause_physics
/reset_simulation
/reset_world
/robot_power
/robot_state_publisher/describe_parameters
/robot_state_publisher/get_parameter_types
/robot_state_publisher/get_parameters
/robot_state_publisher/list_parameters
/robot_state_publisher/set_parameters
/robot_state_publisher/set_parameters_atomically
/rviz2/describe_parameters
/rviz2/get_parameter_types
/rviz2/get_parameters
/rviz2/list_parameters
/rviz2/set_parameters
/rviz2/set_parameters_atomically
/spawn_entity
/teleop_twist_keyboard/describe_parameters
/teleop_twist_keyboard/get_parameter_types
/teleop_twist_keyboard/get_parameters
/teleop_twist_keyboard/list_parameters
/teleop_twist_keyboard/set_parameters
/teleop_twist_keyboard/set_parameters_atomically
/tf_odom_std_dock_link_publisher/describe_parameters
/tf_odom_std_dock_link_publisher/get_parameter_types
/tf_odom_std_dock_link_publisher/get_parameters
/tf_odom_std_dock_link_publisher/list_parameters
/tf_odom_std_dock_link_publisher/set_parameters
/tf_odom_std_dock_link_publisher/set_parameters_atomically
/unpause_physics
/wheel_drop_left_plugin/describe_parameters
/wheel_drop_left_plugin/get_parameter_types
/wheel_drop_left_plugin/get_parameters
/wheel_drop_left_plugin/list_parameters
/wheel_drop_left_plugin/set_parameters
/wheel_drop_left_plugin/set_parameters_atomically
/wheel_drop_right_plugin/describe_parameters
/wheel_drop_right_plugin/get_parameter_types
/wheel_drop_right_plugin/get_parameters
/wheel_drop_right_plugin/list_parameters
/wheel_drop_right_plugin/set_parameters
/wheel_drop_right_plugin/set_parameters_atomically
/wheel_status_publisher_node/describe_parameters
/wheel_status_publisher_node/get_parameter_types
/wheel_status_publisher_node/get_parameters
/wheel_status_publisher_node/list_parameters
/wheel_status_publisher_node/set_parameters
/wheel_status_publisher_node/set_parameters_atomically

Describe the solution you'd like
It would be nice to de-clutter some of the service listings on the sim if possible so that the services actually supported in the robot (specifically e_stop and robot_power) are more clear

@justinIRBT justinIRBT added the enhancement New feature or request label Oct 27, 2021
@slowrunner
Copy link

slowrunner commented Oct 28, 2021

Perhaps turn all "non-physical-bot" items into non-dynamic startup-only items? Then they won't appear in the topic/service/action lists, but can still be configured by the team. By setting startup defaults the non-physical-bot parms would not even be that visible if not in the official documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants