Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwindle: add config option split_bias #7920

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

myQwil
Copy link
Contributor

@myQwil myQwil commented Sep 26, 2024

Describe your PR, what does it fix/add?

If default_split_ratio is greater than 1.0, split_bias will give the bigger half to a specific window:

0 - positional (default)
1 - current window
2 - opening window

For example, using these settings:

dwindle {
    default_split_ratio = 1.2360679775 # 2/phi
    split_bias = 1 # current window
}

We can create a golden spiral

2024-09-26.07-07-34.mp4

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Not that I can think of.

Is it ready for merging, or does it need work?

Ready for merging.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a wiki mr and entry in configDescriptions

@myQwil
Copy link
Contributor Author

myQwil commented Sep 26, 2024

A wiki mr has now been added: hyprwm/hyprland-wiki#786

For the configDescriptions entry, I can see that there are entries in ConfigDescriptions.hpp but I don't see any entries for the dwindle and master layouts.

@vaxerski
Copy link
Member

great, we forgot them... eeeeee alright. I'll have to add them manually I guess, unless you wanna volunteer in a separate mr

vaxerski
vaxerski previously approved these changes Sep 27, 2024
@myQwil
Copy link
Contributor Author

myQwil commented Sep 27, 2024

Sure, I can do that

@myQwil
Copy link
Contributor Author

myQwil commented Sep 27, 2024

Sorry, I needed to run clang-format on the file

If `default_split_ratio` is greater than 1.0, `split_bias` will give the
bigger half to a specific window:

0 - positional (default)
1 - current window
2 - opening window
@vaxerski vaxerski merged commit 2cf6e78 into hyprwm:main Sep 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants