Implement new Input Capture protocol #7919
Draft
+158
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Sep 26, 2024
| @@ -1,6 +1,7 @@ | |||
| [submodule "subprojects/hyprland-protocols"] | |||
| path = subprojects/hyprland-protocols | |||
| url = https://github.com/hyprwm/hyprland-protocols | |||
| url = https://github.com/3l0w/hyprland-protocols | |||
| branch = feat/input-capture-impl | |||
There was a problem hiding this comment.
marking this one as a blocker until this is removed so we dont forget (don't resolve)
vaxerski
reviewed
Sep 26, 2024
# Conflicts: # CMakeLists.txt # src/managers/ProtocolManager.cpp
3l0w
force-pushed
the
feat/input-capture-impl
branch
from
95c44f6
to
d22653e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This PR implements the input capture protocol defined in hyprwm/hyprland-protocols#8.
It also fixed a bug where
wl_output::geometryxandyarguments where always 0.The
wl_output::geometryevent is now sent when the output layout change (Help to followxandymodifications).Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
One bug that i found and i need to investigate, is when i capture every inputs,i can't shortcut into TTYs anymore.
Is it ready for merging, or does it need work?
It still work, like sending the keyboard layout.