Some fixes to XWM #7856
Merged
Some fixes to XWM #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request my review when ready then |
|
I checked. Now is ready |
vaxerski
reviewed
Sep 19, 2024
vaxerski
reviewed
Sep 20, 2024
|
Done |
vaxerski
previously approved these changes
Sep 20, 2024
|
clang-format needed ci fails |
|
Yeah, sorry I'm dumb |
vaxerski
approved these changes
Sep 20, 2024
leiserfg
pushed a commit
to leiserfg/Hyprland
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I didn't implement RAII wrapper for evensources cus lazy.
Is it ready for merging, or does it need work?
NoNow is ready