Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatcher: allow moveintogroup when windows are floating #7818

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Aqa-Ib
Copy link
Contributor

@Aqa-Ib Aqa-Ib commented Sep 16, 2024

Describe your PR, what does it fix/add?

This allows to use the moveintogroup dispatcher when windows are floating.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I don't know why was this disabled in the first place though.

Is it ready for merging, or does it need work?

Yes

This allows to use the moveintogroup dispatcher when windows are floating. I don't know why was this disabled in the first place though.

Cheers!
@vaxerski
Copy link
Member

why would it be useful?

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Sep 17, 2024

I was experimenting trying to script a grouped floating windows workflow. Why do we have this limitation though ?

@vaxerski
Copy link
Member

I think its because it makes little sense

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Sep 17, 2024

Well, it is useful for people that like to use floating grouped windows. Also for consistency sake.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-273C

@vaxerski vaxerski merged commit 0564b46 into hyprwm:main Sep 18, 2024
11 checks passed
leiserfg pushed a commit to leiserfg/Hyprland that referenced this pull request Sep 25, 2024
This allows to use the moveintogroup dispatcher when windows are floating. I don't know why was this disabled in the first place though.

Cheers!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants