Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zsh completion in hyprctl #6467

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix zsh completion in hyprctl #6467

merged 1 commit into from
Jun 19, 2024

Conversation

random2907
Copy link
Contributor

@random2907 random2907 commented Jun 13, 2024

Describe your PR, what does it fix/add?

it fixes hyprctl completion in zsh.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

No.

Is it ready for merging, or does it need work?

yes its ready.

@fufexan
Copy link
Member

fufexan commented Jun 13, 2024

It works fine on my end though, what's not working properly?

@random2907
Copy link
Contributor Author

random2907 commented Jun 13, 2024

It works fine on my end though, what's not working properly?

It is a requirement for zsh-completion to autoload a completion function. same as this #5503.

@leon-erd
Copy link
Contributor

Can confirm the issue. Its also not working on my end since these lines got removed.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about this, sorry. LGTM

@fufexan fufexan merged commit 6e5804b into hyprwm:main Jun 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants