wlr-foreign-toplevel: fix fullscreen failing and add output support #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jun 8, 2024
outfoxxed
force-pushed
the
fix-foreign-toplevel
branch
from
2574694
to
a3ff9df
Compare
outfoxxed
force-pushed
the
fix-foreign-toplevel
branch
from
a3ff9df
to
a8df844
Compare
|
Can't find whats causing an edge case fullscreen bug and fairly sure it's unrelated to these changes. Either way its better off than it was before. Ready to merge again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Foreign toplevel previously didn't fullscreen half the time it was requested (fixed by FULLSCREEN_FULL) and didn't respect output requests. It does both now.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Fullscreening a window on top of another fullscreen window is broken but it was like that before I touched this.
Is it ready for merging, or does it need work?
Ready for merging.