free more memory on destruction #6348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the pointer has a buffer set it wont be freed upon destruction, make asan more happy by adding a destructor and wlr_buf_unlock it on exit.
properly free the animation timer event source on destruction.
properly free the critical signal event source on exit.
|
uhh clang format |
Im trying to figure out what it needs, effing arch being outdated 🥺 |
|
"/__w/Hyprland/Hyprland/src/desktop/Popup.cpp:138:6: error: code should be clang-formatted [-Wclang-format-violations" i mean i didnt even touch that file lol |
yeah i think it comes from this commit 155fe6f heh |
|
just clang-format this and I'll merge it and we'll be done |
clang format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with these most direct leaks reported by asan should be handled, the only thing remaining is the shared/weakptr reports and a few indirect ones inside wlroots/libwayland which im not sure if its just false positives.