Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create Store Presentation #788

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat: Create Store Presentation #788

merged 1 commit into from
Nov 16, 2023

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG commented Nov 15, 2023 •
edited
Loading

Overview

Fixes https://input-output.atlassian.net/browse/ATL-5968

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@CryptoKnightIOG CryptoKnightIOG changed the base branch from main to feat/ZKP-verification November 15, 2023 16:52
@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-6019-Create-Store--Presentation branch from 7d3b6ea to 2660ec3 Compare November 15, 2023 16:53
@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-6019-Create-Store--Presentation branch from 2660ec3 to 0a78ba3 Compare November 15, 2023 17:02
@github-actions GitHub Actions
Copy link
Contributor

Integration Test Results

11 files  11 suites   2s ⏱️
24 tests 24 ✔️ 0 💤 0 ❌
25 runs  25 ✔️ 0 💤 0 ❌

Results for commit 1f41c27.

@github-actions GitHub Actions
Copy link
Contributor

Atala PRISM Test Results

  87 files    87 suites   21m 25s ⏱️
722 tests 714 ✔️ 8 💤 0 ❌
728 runs  720 ✔️ 8 💤 0 ❌

Results for commit 1f41c27.

bvoiturier
bvoiturier approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All we need to validate an incoming presentation! Nice job 👍

@CryptoKnightIOG CryptoKnightIOG merged commit 1dccf3e into feat/ZKP-verification Nov 16, 2023
12 of 15 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-6019-Create-Store--Presentation branch November 16, 2023 13:29
CryptoKnightIOG added a commit that referenced this pull request Nov 18, 2023
@CryptoKnightIOG
feat: Create Store Presentation (#788)
7e18b6a 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Nov 20, 2023
@CryptoKnightIOG
feat: Create Store Presentation (#788)
36c83d1 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Nov 22, 2023
@CryptoKnightIOG
feat: Create Store Presentation (#788)
5376b74 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Nov 30, 2023
@CryptoKnightIOG
feat: Create Store Presentation (#788)
af1e9ea 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Dec 19, 2023
@CryptoKnightIOG
feat: Create Store Presentation (#788)
98a2f3e 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Dec 20, 2023
@CryptoKnightIOG
feat: Create Store Presentation (#788)
6f80e3d 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Jan 3, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
108bbc8 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Jan 24, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
da29d92 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Feb 3, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
651ccdc 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
0724198 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
32e9e51 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Feb 18, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
616018d 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Feb 23, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
4f8b003 
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG added a commit that referenced this pull request Feb 28, 2024
@CryptoKnightIOG
feat: Create Store Presentation (#788)
d3d06b4 
Signed-off-by: Bassam Riman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvoiturier bvoiturier bvoiturier approved these changes

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CryptoKnightIOG @bvoiturier @atala-dev