Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor integration tests - assertions, client models #759

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

antonbaliasnikov
Copy link

Overview

Refactoring of integration tests:

  • Use of client models
  • Remove unused code and wrong assertions
  • Use of Ensure
  • Use of atala automation library
  • Clean ups and fixes

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Integration Test Results

11 files  ±  0  11 suites  ±0   3s ⏱️ ±0s
23 tests  -   2  23 ✔️  -   2  0 💤 ±0  0 ±0 
24 runs   - 13  24 ✔️  - 13  0 💤 ±0  0 ±0 

Results for commit 99a1ae6. ± Comparison against base commit e790efe.

This pull request removes 2 tests.
PRISM DID creation fails when required request fields are missing
PRISM DID creation fails with wrong formatted fields

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Atala PRISM Test Results

  79 files  ±0    79 suites  ±0   15m 18s ⏱️ -36s
680 tests ±0  669 ✔️ ±0  11 💤 ±0  0 ±0 
686 runs  ±0  675 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 99a1ae6. ± Comparison against base commit e790efe.

♻️ This comment has been updated with latest results.

@atala-dev atala-dev added the ci label Oct 14, 2023
@antonbaliasnikov antonbaliasnikov merged commit 43083a3 into main Oct 24, 2023
10 checks passed
@antonbaliasnikov antonbaliasnikov deleted the refactor-integration-tests-part1 branch October 24, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants