fix: ensure all defined performance tests compile and run #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
feature/running-local-performance-tests-squashed
branch
from
23e1f2a
to
325236f
Compare
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
Signed-off-by: David Poltorak <[email protected]>
ghost
force-pushed
the
feature/running-local-performance-tests-squashed
branch
from
9737693
to
406855d
Compare
Signed-off-by: David Poltorak <[email protected]>
yshyn-iohk
reviewed
Oct 3, 2023
| with: | ||
| cmd: webpack | ||
| dir: ${{ env.BENCHMARKING_DIR }} | ||
|
|
||
| - name: Connection Flow Smoke Test | ||
| - name: All Smoke Tests | ||
| env: | ||
| ISSUER_AGENT_API_KEY: default |
There was a problem hiding this comment.
@davidpoltorak-io, you need to make the length of the key at least 16 bytes. I will not work with the current Agent with default value.
There was a problem hiding this comment.
Thanks @yshyn-iohk - I've been struggling to get this branch ready for merging - between performance thresholds being passed and some failed runs - this really helps - I'll make the change and retest
yshyn-iohk
approved these changes
Oct 3, 2023
|
Deprecating this PR in favour of https://github.com/hyperledger-labs/open-enterprise-agent/pull/750/files which includes a one command |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes all perforrmance tests currently part of the k6 code base. Previously - some didn't work due to issues with the
json()serialisation function and there was inconsitency in scenarios and thresholds.Now - all tests run and pass on a local testing stack (will commit this in a future PR) and use the same defaults for a smoke test
Checklist
My PR contains...
My changes...
Documentation
Tests