Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prism-agent): use JWK in DIDSecretStorage #644

Closed
wants to merge 1 commit into from

Conversation

bvoiturier
Copy link
Contributor

Overview

Fixes ATL-xxxx

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Atala PRISM Test Results

  63 files  ±0    63 suites  ±0   8m 6s ⏱️ -18s
531 tests ±0  520 ✔️ ±0  11 💤 ±0  0 ±0 
534 runs  ±0  523 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 399cfaa. ± Comparison against base commit 756dea7.

@github-actions
Copy link
Contributor

E2E Test Results

10 files  ±0  10 suites  ±0   6m 0s ⏱️ +8s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ±0 
32 runs  ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 399cfaa. ± Comparison against base commit 756dea7.

@BS-IO BS-IO removed the mercury label Nov 28, 2023
@ghost
Copy link

ghost commented Jan 25, 2024

Hey @bvoiturier - This is quite an old PR - do we need this? Can we finish it up or close it out as not needed?

@bvoiturier
Copy link
Contributor Author

Hey @bvoiturier - This is quite an old PR - do we need this? Can we finish it up or close it out as not needed?

Thanks for pointing out @davidpoltorak-io . This PR is obsolete, I will cancel it 👍

@bvoiturier bvoiturier closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants