Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: did wallet mapping multitenancy #625

Merged
merged 3 commits into from
Aug 17, 2023
Merged

feat: did wallet mapping multitenancy #625

merged 3 commits into from
Aug 17, 2023

Conversation

mineme0110
Copy link
Contributor

Overview

Fixes ATL-5179

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@patlo-iog
Copy link
Contributor

patlo-iog commented Aug 16, 2023 •
edited
Loading

Let's try to merge into feat/mt-walletapi-isolation branch. That branch is currently our main multi-tenant branch. When it is stable enough, we'll merge into main.

yshyn-iohk
yshyn-iohk approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Are we ready to merge it into the main branch?
Does it make sense to keep the changes in the isolated branch?

@mineme0110
Copy link
Contributor Author

mineme0110 commented Aug 17, 2023 •
edited
Loading

Good job! Are we ready to merge it into the main branch? Does it make sense to keep the changes in the isolated branch?

Technically we could merge in main branch as this is not integrated, I branched from the feat/mt-walletapi-isolation, So I am on to merge to main or to feat/mt-walletapi-isolation , I think better to merge with feat/mt-walletapi-isolation

@mineme0110 mineme0110 changed the base branch from main to feat/mt-walletapi-isolation August 17, 2023 08:35
@mineme0110 mineme0110 changed the title [WIP] feat/did wallet mapping multitenancy feat: did wallet mapping multitenancy Aug 17, 2023
@mineme0110 mineme0110 force-pushed the feat/did-wallet-mappin-multitenancy branch from 648531a to f039954 Compare August 17, 2023 08:42
@mineme0110 mineme0110 force-pushed the feat/did-wallet-mappin-multitenancy branch from f039954 to 5f88de8 Compare August 17, 2023 08:44
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023 •
edited
Loading

Atala PRISM Test Results

  68 files    68 suites   9m 53s ⏱️
579 tests 568 ✔️ 11 💤 0 ❌
584 runs  573 ✔️ 11 💤 0 ❌

Results for commit 7405969.

♻️ This comment has been updated with latest results.

@mineme0110
scalafmt error fix
7405969 
Signed-off-by: Shailesh Patil <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

E2E Test Results

10 files  10 suites   5m 43s ⏱️
21 tests 21 ✔️ 0 💤 0 ❌
32 runs  32 ✔️ 0 💤 0 ❌

Results for commit 7405969.

@mineme0110 mineme0110 merged commit 7405969 into feat/mt-walletapi-isolation Aug 17, 2023
8 of 9 checks passed
@mineme0110 mineme0110 deleted the feat/did-wallet-mappin-multitenancy branch August 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

@FabioPinheiro FabioPinheiro Awaiting requested review from FabioPinheiro

@bvoiturier bvoiturier Awaiting requested review from bvoiturier

@antonbaliasnikov antonbaliasnikov Awaiting requested review from antonbaliasnikov

@CryptoKnightIOG CryptoKnightIOG Awaiting requested review from CryptoKnightIOG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mineme0110 @patlo-iog @yshyn-iohk @atala-dev