Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prism-agent): expose connect/issue/presentation records 'thid' and add it to REST API queries #583

Merged
merged 8 commits into from
Jul 6, 2023
Merged

feat(prism-agent): expose connect/issue/presentation records 'thid' and add it to REST API queries #583

merged 8 commits into from
Jul 6, 2023

Conversation

bvoiturier
Copy link
Contributor

Overview

Fixes ATL-5017

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

Atala PRISM Test Results

  56 files    56 suites   7m 12s ⏱️
488 tests 477 ✔️ 11 💤 0 ❌
489 runs  478 ✔️ 11 💤 0 ❌

Results for commit 28f4460.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

Atala PRISM Code Coverage

File Coverage
All files 23% ✅

Minimum allowed coverage is 12%

Generated by 🐒 cobertura-action against 28f4460

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

E2E Test Results

11 files  ±0  11 suites  ±0   6m 15s ⏱️ -7s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
32 runs  ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 28f4460. ± Comparison against base commit c9e69f6.

♻️ This comment has been updated with latest results.

@bvoiturier bvoiturier marked this pull request as ready for review July 6, 2023 13:03
@bvoiturier bvoiturier requested review from patlo-iog and removed request for mineme0110, CryptoKnightIOG and patlo-iog July 6, 2023 13:03
@bvoiturier bvoiturier merged commit 9a97c7a into main Jul 6, 2023
8 checks passed
@bvoiturier bvoiturier deleted the feature/ATL-5017-expose-thid branch July 6, 2023 13:38
atala-dev added a commit that referenced this pull request Jul 10, 2023
@atala-dev
chore(release): cut atala prism 1.7.0 release
1b3b219 
# [1.7.0](prism-agent-v1.6.0...prism-agent-v1.7.0) (2023-07-10)

### Bug Fixes

* Adding Apollo ADR ([#573](#573)) ([e036bc8](e036bc8))
* **castor:** fix DID parser that failing to parse some DIDs ([#581](#581)) ([24b2300](24b2300))
* **pollux:** add pagination at db level for getCredentialRecords ([#586](#586)) ([c0db5c8](c0db5c8))

### Features

* **prism-agent:** add http metrics ([#585](#585)) ([f62d7f5](f62d7f5))
* **prism-agent:** align DID document service handling with the spec ([#582](#582)) ([c9e69f6](c9e69f6))
* **prism-agent:** expose connect/issue/presentation records 'thid' and add it to REST API queries ([#583](#583)) ([9a97c7a](9a97c7a))
* **prism-agent:** simple event mechanism using webhook ([#575](#575)) ([42cf8c9](42cf8c9)), closes [#1](#1)

### Performance Improvements

* add k6 connection flow running in CI ([#572](#572)) ([601f934](601f934))
bvoiturier added a commit that referenced this pull request Aug 21, 2023
@bvoiturier
I, Benjamin Voiturier hereby sign-off-by all of my past commits to th…
a691f74 
…is repo subject to the Developer Certificate of Origin (DCO), Version 1.1.

301fbab feat(agent): improve OAS spec and refactor DidCommHttpServer code (#615)
47b273a chore(prism-agent): solve Tapir <> static OAS desync issue (#591)
cf207fc docs(prism-agent): add basic webhook code snippet (#589)
5661f8c docs(prism-agent): document event 'type' field (#588)
42cf8c9 feat(prism-agent): simple event mechanism using webhook (#575)
9a97c7a feat(prism-agent): expose connect/issue/presentation records 'thid' and add it to REST API queries (#583)
ede234b fix(prism-agent): use correct pairwise DIDs in presentation flow (#568)
ab88736 feat(prism-agent): integrate credential schema into VC issue flow (#541)
c300c3f chore(prism-agent): split ManagedDIDService in trait & impl (#538)
6a26bb7 fix(prism-agent): infinite loop in proof presentation execution (#540)
904a2dc feat(prism-agent): fix infinite reprocessing of records in error (#528)
cb01657 feat(prism-agent): migrate present-proof endpoints to Tapir (#525)
9bd132e docs(prism-agent): add connect/issue/verify sequence diagrams (#470)
876dd9e feat(prism-agent): migrate connect endpoints to Tapir (#493)
44f06cc feat(prism-agent): insert bouncy-castle security as 2nd provider globally in agent entry point (#477)
5324e14 test(pollux): fix ECDSA unit tests so they work with recent JDK versions (#476)
d7813ba feat(prism-agent): move subjectId field from issuer to holder (#435)
434f1fd feat(pollux): move subjectId field from issuer side to holder side (#434)
b8e13d7 docs(prism-agent): add present proof protocol doc (#409)
146cd52 feat(prism-agent): ATL-3554 clean-up OAS and remove unused endpoints and definitions (#376)
2ce9163 docs(prism-agent): improve OAS documentation for connect and issue. (#375)
c77f160 feat(prism-agent): ATL-3349 connection state issue and perf improvements (#359)
28f779a feat(pollux): bump mercury version and fix queries (#357)
957bdea feat(connect): bump mercury version and fix queries (#356)
7673278 feat(connect): support connect records retrieval by states (#349)
f810ee3 feat(pollux): support issue/presentation records retrieval by states (#350)
b0a14d4 feat(pollux): get rid of 'drop(1)' and 'dropRight(1)' on credential attachment value (#341)
295ca7a test(pollux): improve test coverage on issue protocol (#332)
cb17acf feat(prism-agent): remove connection deletion enpoint from OAS spec (#323)
1bbb02f test(connect): add unit tests on connect and issue
030a257 feat(prism-agent): add 'GET /present-proof/presentations/{id}' endpoint (#282)
eff3918 feat(prism-agent): allow connection reuse when creating credential offer (#276)
ce4758b feat(prism-agent): bump mercury, pollux and connect versions (#273)
70f878c feat(connect): bump mercury version (#272)
a31f379 feat(pollux): bump mercury version (#271)
8a1e5c3 feat(mercury): dumb release commit (#270)
21b5dec feat(mercury): empty release commit (#268)
2529f62 Issue vc with prism did (#267)
bb04ca4 feat(prism-agent): use pairwise DID in proof presentation flow (#260)
d199f0d feat(prism-agent): integrate latest pollux version (#259)
4424de1 feat(prism-agent): fix DB connection pool duplication issue by providing ZLayer globally (#256)
01519ff feat(prism-agent): Use pairwise PeerDIDs in connect and issue (#253)
38a9b95 feat(pollux): use dedicated pairwise PeerDIDs instead of a global one (#252)
1dc7339 feat(prism-agent): fix prism-agent major issues (#199)
6fffde2 feat(pollux): validate the current record state on each protocol action received (#193)
4a7a312 chore(infra): fix prism-agent docker image version (#185)
dc8d86b feat(prism-agent): add connect/issue doc + allow local execution of multiple Prism Agent instances (#178)
4573ef8 feat(pollux): minor changes related to connect implementation (#171)
b707792 feat(connect): implement Connect protocol (#172)
f3cb60e feat(prism-agent): implement Issue Credential v2 protocol (#146)
a80702f feat(pollux): implement Issue Credential v2 Protocol (#144)
7c1f50a feat(agent): [ATL-2005] implement REST API for credential issuance (#86)
380d024 fix(architecture): use explicit version number for Structurizr Lite docker image (#11)
cbb2943 docs(openapi): add mob session spec
ec8fde4 docs(architecture): add README.md for local deployment
9b76ce3 chore(architecture): add docker-compose.yml for documentation deployment
e87eafc chore(architecture): add Dockerfile for Atala custom Structurizr image
36510e2 docs(architecture): Add base C4 diagrams DSL

Signed-off-by: Benjamin Voiturier <[email protected]>
antonbaliasnikov pushed a commit that referenced this pull request Aug 21, 2023
@bvoiturier
I, Benjamin Voiturier hereby sign-off-by all of my past commits to th…
3b163f1 
…is repo subject to the Developer Certificate of Origin (DCO), Version 1.1.

301fbab feat(agent): improve OAS spec and refactor DidCommHttpServer code (#615)
47b273a chore(prism-agent): solve Tapir <> static OAS desync issue (#591)
cf207fc docs(prism-agent): add basic webhook code snippet (#589)
5661f8c docs(prism-agent): document event 'type' field (#588)
42cf8c9 feat(prism-agent): simple event mechanism using webhook (#575)
9a97c7a feat(prism-agent): expose connect/issue/presentation records 'thid' and add it to REST API queries (#583)
ede234b fix(prism-agent): use correct pairwise DIDs in presentation flow (#568)
ab88736 feat(prism-agent): integrate credential schema into VC issue flow (#541)
c300c3f chore(prism-agent): split ManagedDIDService in trait & impl (#538)
6a26bb7 fix(prism-agent): infinite loop in proof presentation execution (#540)
904a2dc feat(prism-agent): fix infinite reprocessing of records in error (#528)
cb01657 feat(prism-agent): migrate present-proof endpoints to Tapir (#525)
9bd132e docs(prism-agent): add connect/issue/verify sequence diagrams (#470)
876dd9e feat(prism-agent): migrate connect endpoints to Tapir (#493)
44f06cc feat(prism-agent): insert bouncy-castle security as 2nd provider globally in agent entry point (#477)
5324e14 test(pollux): fix ECDSA unit tests so they work with recent JDK versions (#476)
d7813ba feat(prism-agent): move subjectId field from issuer to holder (#435)
434f1fd feat(pollux): move subjectId field from issuer side to holder side (#434)
b8e13d7 docs(prism-agent): add present proof protocol doc (#409)
146cd52 feat(prism-agent): ATL-3554 clean-up OAS and remove unused endpoints and definitions (#376)
2ce9163 docs(prism-agent): improve OAS documentation for connect and issue. (#375)
c77f160 feat(prism-agent): ATL-3349 connection state issue and perf improvements (#359)
28f779a feat(pollux): bump mercury version and fix queries (#357)
957bdea feat(connect): bump mercury version and fix queries (#356)
7673278 feat(connect): support connect records retrieval by states (#349)
f810ee3 feat(pollux): support issue/presentation records retrieval by states (#350)
b0a14d4 feat(pollux): get rid of 'drop(1)' and 'dropRight(1)' on credential attachment value (#341)
295ca7a test(pollux): improve test coverage on issue protocol (#332)
cb17acf feat(prism-agent): remove connection deletion enpoint from OAS spec (#323)
1bbb02f test(connect): add unit tests on connect and issue
030a257 feat(prism-agent): add 'GET /present-proof/presentations/{id}' endpoint (#282)
eff3918 feat(prism-agent): allow connection reuse when creating credential offer (#276)
ce4758b feat(prism-agent): bump mercury, pollux and connect versions (#273)
70f878c feat(connect): bump mercury version (#272)
a31f379 feat(pollux): bump mercury version (#271)
8a1e5c3 feat(mercury): dumb release commit (#270)
21b5dec feat(mercury): empty release commit (#268)
2529f62 Issue vc with prism did (#267)
bb04ca4 feat(prism-agent): use pairwise DID in proof presentation flow (#260)
d199f0d feat(prism-agent): integrate latest pollux version (#259)
4424de1 feat(prism-agent): fix DB connection pool duplication issue by providing ZLayer globally (#256)
01519ff feat(prism-agent): Use pairwise PeerDIDs in connect and issue (#253)
38a9b95 feat(pollux): use dedicated pairwise PeerDIDs instead of a global one (#252)
1dc7339 feat(prism-agent): fix prism-agent major issues (#199)
6fffde2 feat(pollux): validate the current record state on each protocol action received (#193)
4a7a312 chore(infra): fix prism-agent docker image version (#185)
dc8d86b feat(prism-agent): add connect/issue doc + allow local execution of multiple Prism Agent instances (#178)
4573ef8 feat(pollux): minor changes related to connect implementation (#171)
b707792 feat(connect): implement Connect protocol (#172)
f3cb60e feat(prism-agent): implement Issue Credential v2 protocol (#146)
a80702f feat(pollux): implement Issue Credential v2 Protocol (#144)
7c1f50a feat(agent): [ATL-2005] implement REST API for credential issuance (#86)
380d024 fix(architecture): use explicit version number for Structurizr Lite docker image (#11)
cbb2943 docs(openapi): add mob session spec
ec8fde4 docs(architecture): add README.md for local deployment
9b76ce3 chore(architecture): add docker-compose.yml for documentation deployment
e87eafc chore(architecture): add Dockerfile for Atala custom Structurizr image
36510e2 docs(architecture): Add base C4 diagrams DSL

Signed-off-by: Benjamin Voiturier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@antonbaliasnikov antonbaliasnikov Awaiting requested review from antonbaliasnikov

@FabioPinheiro FabioPinheiro Awaiting requested review from FabioPinheiro

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

Assignees
No one assigned
Labels
Component: Cloud Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvoiturier @yshyn-iohk @atala-dev