Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust Kotlin and TypeScript HTTP client to use the schemaId f… #1388

Merged
merged 11 commits into from
Oct 9, 2024
Merged

fix: adjust Kotlin and TypeScript HTTP client to use the schemaId f… #1388

merged 11 commits into from
Oct 9, 2024

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Oct 7, 2024 •
edited
Loading

…rom VCDM2.0 (string or list of strings)

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk
fix: adjust Kotlin and TypeScript HTTP client to use the schemaId f…
4dfb04c 
…rom VCDM2.0 (string or list of strings)

Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk requested a review from a team as a code owner October 7, 2024 11:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Unit Test Results

102 files  ±0  102 suites  ±0   19m 17s ⏱️ -35s
874 tests ±0  866 ✅ ±0  8 💤 ±0  0 ❌ ±0 
881 runs  ±0  873 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c820782. ± Comparison against base commit 7b4a9c1.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 7, 2024 •
edited
Loading

Coverage Status

coverage: 48.653%. remained the same
when pulling c820782 on fix/update-test-depedencies
into 7b4a9c1 on main.

mattklepp
mattklepp approved these changes Oct 7, 2024
View reviewed changes
Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
49 tests ±0  49 ✅ ±0  0 💤 ±0  0 ❌ ±0 
88 runs  ±0  88 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c820782. ± Comparison against base commit 7b4a9c1.

♻️ This comment has been updated with latest results.

mattklepp
mattklepp approved these changes Oct 7, 2024
View reviewed changes
Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent.

@github-actions github-actions bot added the ci label Oct 9, 2024
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) October 9, 2024 07:03
@yshyn-iohk yshyn-iohk merged commit c2da492 into main Oct 9, 2024
13 checks passed
@yshyn-iohk yshyn-iohk deleted the fix/update-test-depedencies branch October 9, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklepp mattklepp mattklepp approved these changes

Assignees
No one assigned
Labels
ci cloud-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshyn-iohk @coveralls @mattklepp