feat: Default Backend API to Array Of Credential Schema #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshyn-iohk
reviewed
Sep 19, 2024
| @@ -69,7 +65,7 @@ class IssueControllerImpl( | |||
| pairwiseHolderDID = offerContext.pairwiseHolderDID, | |||
| kidIssuer = request.issuingKid, | |||
| thid = DidCommID(), | |||
| maybeSchemaId = request.schemaId, | |||
| maybeSchemaIds = Applicative[Option].map2(request.schemaIds, request.schemaId.map(List(_)))(_ ++ _), | |||
There was a problem hiding this comment.
@CryptoKnightIOG, two fields might contain schemaId: schemaId and schemaIds.
Remember, I recommended splitting VCDM 1.1 and 2.0 at the domain level, but I see that the API also should be segregated.
Otherwise, the result API is going to be overloaded and slightly weird.
There was a problem hiding this comment.
If you are still going to go this way, use the same REST API for both models. I recommend deleting schemaIds and allowing schemaId to be either String or List[String].
There was a problem hiding this comment.
I fixed it this PR #1368
yshyn-iohk
approved these changes
Sep 19, 2024
yshyn-iohk
approved these changes
Sep 23, 2024
CryptoKnightIOG
force-pushed
the
ATL-7775
branch
2 times, most recently
from
2fc12f6
to
00d9698
Compare
Signed-off-by: Bassam Riman <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
force-pushed
the
ATL-7775
branch
from
00d9698
to
33c5194
Compare
Signed-off-by: Bassam Riman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://input-output.atlassian.net/browse/ATL-7775