Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code SchemaValidator #1296

Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore: remove dead code SchemaValidator #1296

merged 1 commit into from
Aug 22, 2024

Conversation

patlo-iog
Copy link
Contributor

Description:

Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable.
Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ce58865. ± Comparison against base commit a7d51b6.

Copy link
Contributor

Unit Test Results

 96 files  + 54   96 suites  +54   23m 16s ⏱️ + 21m 32s
826 tests +511  818 ✅ +511  8 💤 ±0  0 ❌ ±0 
833 runs  +518  825 ✅ +518  8 💤 ±0  0 ❌ ±0 

Results for commit ce58865. ± Comparison against base commit a7d51b6.

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@patlo-iog patlo-iog merged commit 6f8c9ff into main Aug 22, 2024
12 checks passed
@patlo-iog patlo-iog deleted the jsonschema-cleanup branch August 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants