feat: ATL-6833 integrate ZIO failures and defects in wallet event controller #1186

bvoiturier · 2024-06-14T15:32:02Z

Description:

ATL-6833

Checklist:

My PR follows the contribution guidelines of this project
My PR is free of third-party dependencies that don't comply with the Allowlist
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked the PR title to follow the conventional commit specification

…e TooManyWebhook + DuplicateWalletSeed errors at service level Signed-off-by: Benjamin Voiturier <[email protected]>

…effects Signed-off-by: Benjamin Voiturier <[email protected]>

…llet-event-controller Signed-off-by: Benjamin Voiturier <[email protected]>

…rait Signed-off-by: Benjamin Voiturier <[email protected]>

…llet-event-controller Signed-off-by: Benjamin Voiturier <[email protected]>

…llet-event-controller

github-actions · 2024-06-14T15:34:12Z

Unit Test Results

96 files ±0 96 suites ±0 22m 14s ⏱️ -7s
826 tests +1 818 ✅ +1 8 💤 ±0 0 ❌ ±0
833 runs +1 825 ✅ +1 8 💤 ±0 0 ❌ ±0

Results for commit 132862f. ± Comparison against base commit 628f2f0.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.

org.hyperledger.identus.agent.walletapi.storage.JdbcWalletNonSecretStorageSpec ‑ JdbcWalletNonSecretStorage - walletNotification - unable to create new notification if exceed limit

org.hyperledger.identus.agent.walletapi.service.WalletManagementServiceSpec ‑ WalletManagementService - jdbc as secret storage - webhook spec - cannot create more notifications than the limit
org.hyperledger.identus.agent.walletapi.service.WalletManagementServiceSpec ‑ WalletManagementService - vault as secret storage - webhook spec - cannot create more notifications than the limit

♻️ This comment has been updated with latest results.

Signed-off-by: Benjamin Voiturier <[email protected]>

…et with an exisitng ID Signed-off-by: Benjamin Voiturier <[email protected]>

Signed-off-by: Benjamin Voiturier <[email protected]>

github-actions · 2024-06-14T19:17:05Z

Integration Test Results

15 files ±0 15 suites ±0 2s ⏱️ ±0s
33 tests ±0 33 ✅ ±0 0 💤 ±0 0 ❌ ±0
46 runs ±0 46 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 132862f. ± Comparison against base commit 628f2f0.

# [1.37.0-snapshot.test.1](cloud-agent-v1.36.1...cloud-agent-v1.37.0-snapshot.test.1) (2024-07-01) ### Bug Fixes * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) ### Features * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]>

# [1.37.0-snapshot.test.1](cloud-agent-v1.36.1...cloud-agent-v1.37.0-snapshot.test.1) (2024-07-01) ### Bug Fixes * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) ### Features * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>

Signed-off-by: Pat Losoponkul <[email protected]> test: remove println Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.37.0-snapshot.test.1 release * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>

# [1.37.0](cloud-agent-v1.36.1...cloud-agent-v1.37.0) (2024-07-01) ### Bug Fixes * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) ### Features * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]>

bvoiturier added 5 commits June 14, 2024 11:50

chore(wallet-api): get tid of non-secret repo error classes and manag…

323e864

…e TooManyWebhook + DuplicateWalletSeed errors at service level Signed-off-by: Benjamin Voiturier <[email protected]>

chore(wallet-api): refactor WalletSecretStorage methods to unfailing …

75c388f

…effects Signed-off-by: Benjamin Voiturier <[email protected]>

Merge branch 'main' into feat/ATL-6833-zio-failures-and-defects-in-wa…

f5382df

…llet-event-controller Signed-off-by: Benjamin Voiturier <[email protected]>

feat(wallet-api): make all service errors extend the shared Failure t…

87878f3

…rait Signed-off-by: Benjamin Voiturier <[email protected]>

Merge branch 'main' into feat/ATL-6833-zio-failures-and-defects-in-wa…

83ae8fb

…llet-event-controller Signed-off-by: Benjamin Voiturier <[email protected]>

bvoiturier requested review from yshyn-iohk and patlo-iog as code owners June 14, 2024 15:32

Merge branch 'main' into feat/ATL-6833-zio-failures-and-defects-in-wa…

3af55eb

…llet-event-controller

github-actions bot added the cloud-agent label Jun 14, 2024

chore: run scalafmt

79594f7

Signed-off-by: Benjamin Voiturier <[email protected]>

yshyn-iohk approved these changes Jun 14, 2024

View reviewed changes

bvoiturier added 4 commits June 14, 2024 18:49

fix(wallet-api): return 422 unprocessable entity when creating a wall…

dc09b7e

…et with an exisitng ID Signed-off-by: Benjamin Voiturier <[email protected]>

chore: run scalafmt

978ad69

Signed-off-by: Benjamin Voiturier <[email protected]>

feat: register 422 as a basic response status code

b00d049

Signed-off-by: Benjamin Voiturier <[email protected]>

tests: fix integration tests

132862f

Signed-off-by: Benjamin Voiturier <[email protected]>

bvoiturier requested review from todorkoleviohk, amagyar-iohk and mineme0110 as code owners June 14, 2024 19:05

bvoiturier merged commit 8bc2018 into main Jun 14, 2024
10 checks passed

bvoiturier deleted the feat/ATL-6833-zio-failures-and-defects-in-wallet-event-controller branch June 14, 2024 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ATL-6833 integrate ZIO failures and defects in wallet event controller #1186

feat: ATL-6833 integrate ZIO failures and defects in wallet event controller #1186

bvoiturier commented Jun 14, 2024

github-actions bot commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024

feat: ATL-6833 integrate ZIO failures and defects in wallet event controller #1186

feat: ATL-6833 integrate ZIO failures and defects in wallet event controller #1186

Conversation

bvoiturier commented Jun 14, 2024

Description:

Checklist:

github-actions bot commented Jun 14, 2024 • edited Loading

Unit Test Results

github-actions bot commented Jun 14, 2024

Integration Test Results

github-actions bot commented Jun 14, 2024 •

edited

Loading