feat: add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof #1127

shotexa · 2024-06-02T01:17:59Z

Description:

Adds support for EcdsaSecp256k1Signature2019Proof for secp256k1 keys and fixes multikey encoding in EddsaJcs2022Proof. Corresponding update in docs: #1167

Alternatives Considered (optional):

Checklist:

My PR follows the contribution guidelines of this project
My PR is free of third-party dependencies that don't comply with the Allowlist
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked the PR title to follow the conventional commit specification

Signed-off-by: Shota Jolbordi <[email protected]>

github-actions · 2024-06-02T01:19:38Z

Unit Test Results

96 files ±0 96 suites ±0 22m 27s ⏱️ + 2m 24s
826 tests ±0 818 ✅ ±0 8 💤 ±0 0 ❌ ±0
833 runs ±0 825 ✅ ±0 8 💤 ±0 0 ❌ ±0

Results for commit 9b52b9d. ± Comparison against base commit a4ce87f.

♻️ This comment has been updated with latest results.

shared/core/src/main/scala/org/hyperledger/identus/shared/utils/Json.scala

Signed-off-by: Shota Jolbordi <[email protected]>

pollux/vc-jwt/src/main/scala/org/hyperledger/identus/pollux/vc/jwt/JsonWebKey.scala

mkbreuningIOHK · 2024-06-06T12:17:54Z

@shotexa , if this PR is NOT TO BE MERGED, should it be a Draft PR instead?
In any case, please clarify why it is NOT TO BE MERGED as the description should explain it for the reviewers. What is left so this PR can be merged shall be added.
cc @yshyn-iohk @patlo-iog

Signed-off-by: Shota Jolbordi <[email protected]>

github-actions · 2024-06-18T13:29:50Z

Integration Test Results

15 files ±0 15 suites ±0 2s ⏱️ ±0s
33 tests ±0 33 ✅ ±0 0 💤 ±0 0 ❌ ±0
46 runs ±0 46 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 9b52b9d. ± Comparison against base commit a4ce87f.

♻️ This comment has been updated with latest results.

# [1.37.0-snapshot.test.1](cloud-agent-v1.36.1...cloud-agent-v1.37.0-snapshot.test.1) (2024-07-01) ### Bug Fixes * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) ### Features * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]>

# [1.37.0-snapshot.test.1](cloud-agent-v1.36.1...cloud-agent-v1.37.0-snapshot.test.1) (2024-07-01) ### Bug Fixes * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) ### Features * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>

Signed-off-by: Pat Losoponkul <[email protected]> test: remove println Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.37.0-snapshot.test.1 release * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>

# [1.37.0](cloud-agent-v1.36.1...cloud-agent-v1.37.0) (2024-07-01) ### Bug Fixes * avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24)) * incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75)) * KeyID from String to Opaque Type and presentation job cleanup ([#1190](#1190)) ([b813faf](b813faf)) * make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062)) * migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479)) * Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447)) * Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b)) * present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52)) * Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c)) ### Features * add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc)) * add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83)) * add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded)) * **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554)) * ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d)) * ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094)) * ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018)) * ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77)) * Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9)) * implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f)) * improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20)) * Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120)) * SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0)) * use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda)) * use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651)) Signed-off-by: Allain Magyar <[email protected]>

Shota Jolbordi added 5 commits May 26, 2024 00:16

Add rdf canonicalization function

859f6d2

Signed-off-by: Shota Jolbordi <[email protected]>

Add new proof encoder and decoder

1f82d7b

Signed-off-by: Shota Jolbordi <[email protected]>

Remove slId from vcStatusList2021

e338932

Signed-off-by: Shota Jolbordi <[email protected]>

Add EddsaJcs2022ProofGenerator

4e63b26

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

05b2dc9

Signed-off-by: Shota Jolbordi <[email protected]>

shotexa requested review from patlo-iog, FabioPinheiro, mineme0110, yshyn-iohk, bvoiturier and CryptoKnightIOG as code owners June 2, 2024 01:18

github-actions bot added pollux build shared labels Jun 2, 2024

yshyn-iohk reviewed Jun 3, 2024

View reviewed changes

shared/core/src/main/scala/org/hyperledger/identus/shared/utils/Json.scala Show resolved Hide resolved

yshyn-iohk approved these changes Jun 3, 2024

View reviewed changes

Fix formatting

d8e164a

Signed-off-by: Shota Jolbordi <[email protected]>

patlo-iog reviewed Jun 6, 2024

View reviewed changes

pollux/vc-jwt/src/main/scala/org/hyperledger/identus/pollux/vc/jwt/JsonWebKey.scala Outdated Show resolved Hide resolved

Shota Jolbordi added 4 commits June 7, 2024 17:49

Fix status list unit test

0369f6c

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

fb8e25f

Signed-off-by: Shota Jolbordi <[email protected]>

Formatting

fe94b2a

Signed-off-by: Shota Jolbordi <[email protected]>

Fix the flow

0d2fe9e

Signed-off-by: Shota Jolbordi <[email protected]>

github-actions bot added the cloud-agent label Jun 7, 2024

shotexa added 3 commits June 8, 2024 02:42

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

bd4cd79

Use derived decoder for json web key

e4d1b2f

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

2933928

shotexa mentioned this pull request Jun 10, 2024

docs: update docs for JWT revocation [skip ci] #1167

Merged

6 tasks

shotexa self-assigned this Jun 10, 2024

Shota Jolbordi added 7 commits June 13, 2024 04:19

Remove check for the curve to improve performance

67bebf3

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

ddbe8ca

Signed-off-by: Shota Jolbordi <[email protected]>

Fix compilation errors

60f76cf

Signed-off-by: Shota Jolbordi <[email protected]>

scalafmtAll

5d00899

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

f0d444f

Signed-off-by: Shota Jolbordi <[email protected]>

Fix compilation errors

fa91779

Signed-off-by: Shota Jolbordi <[email protected]>

Increase wait times in some tests

0d8582a

Signed-off-by: Shota Jolbordi <[email protected]>

shotexa requested review from todorkoleviohk and amagyar-iohk as code owners June 18, 2024 12:46

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

3f603e0

shotexa removed request for amagyar-iohk and todorkoleviohk June 18, 2024 13:26

Merge branch 'main' into ATL-7120-add-proof-type-for-secp256k1

9b52b9d

shotexa merged commit e617ded into main Jun 18, 2024
11 checks passed

shotexa deleted the ATL-7120-add-proof-type-for-secp256k1 branch June 18, 2024 22:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof #1127

feat: add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof #1127

shotexa commented Jun 2, 2024 •

edited

Loading

github-actions bot commented Jun 2, 2024 •

edited

Loading

mkbreuningIOHK commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

feat: add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof #1127

feat: add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof #1127

Conversation

shotexa commented Jun 2, 2024 • edited Loading

Description:

Alternatives Considered (optional):

Checklist:

github-actions bot commented Jun 2, 2024 • edited Loading

Unit Test Results

mkbreuningIOHK commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 18, 2024 • edited Loading

Integration Test Results

shotexa commented Jun 2, 2024 •

edited

Loading

github-actions bot commented Jun 2, 2024 •

edited

Loading

mkbreuningIOHK commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading