Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Dependency updates & Code Enhancements #91

Closed
wants to merge 1 commit into from
Closed

refactor: Dependency updates & Code Enhancements #91

wants to merge 1 commit into from

Conversation

hamada147
Copy link
Contributor

@hamada147 hamada147 commented Sep 20, 2023 •
edited by jira bot
Loading

ATL-5783
ATL-5747
ATL-5746
ATL-5745
ATL-5743
ATL-5740
ATL-5739
ATL-5738
ATL-5737
ATL-5736
ATL-5735
ATL-5734

  • Remove pod spec files as we moved from CocoaPods to SPM
  • Update most dependencies
  • Commented RSA Keys classes and objects as we no longer support RSA
  • Update def files and Gradle script to support all Apple targets
  • Update README for each module

@hamada147 hamada147 added the enhancement New feature or request label Sep 20, 2023
@hamada147 hamada147 self-assigned this Sep 20, 2023
@atala-dev
Copy link
Contributor

atala-dev commented Sep 20, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 98 0 0.19s
✅ KOTLIN ktlint 74 0 132.33s
⚠️ MARKDOWN markdownlint 11 74 0.56s
✅ MARKDOWN markdown-link-check 11 0 7.3s
⚠️ MARKDOWN markdown-table-formatter 11 1 0.39s
⚠️ REPOSITORY devskim yes 6 0.82s
✅ REPOSITORY dustilock yes no 0.05s
✅ REPOSITORY gitleaks yes no 1.13s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 4.54s
✅ REPOSITORY syft yes no 0.42s
✅ REPOSITORY trivy yes no 3.85s
✅ XML xmllint 1 0 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@hamada147 hamada147 force-pushed the platform-update branch 9 times, most recently from 28139ca to 589a647 Compare September 20, 2023 07:47
@atala-dev
Copy link
Contributor

atala-dev commented Sep 20, 2023 •
edited
Loading

Code Coverage

File Coverage [96.47%] ✅
base-asymmetric-encryption/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicCodeEnglish.kt 100.00% ✅
base-symmetric-encryption/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMSymmetricKey.kt 0.00% ❌
base-symmetric-encryption/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMSymmetricKey.kt 0.00% ❌
base-symmetric-encryption/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMSymmetricKey.kt 0.00% ❌
base-symmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMSymmetricKey.kt 0.00% ❌
base-symmetric-encryption/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMSymmetricKey.kt 0.00% ❌
hashing/src/iosMain/kotlin/io/iohk/atala/prism/apollo/hashing/PBKDF2SHA512.kt 50.00% ❌
secp256k1-kmp/src/commonMain/kotlin/fr/acinq/secp256k1/Secp256k1.kt 9.09% ❌
secure-random/src/iosMain/kotlin/io/iohk/atala/prism/apollo/securerandom/SecureRandom.kt 100.00% ✅
utils/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/Validated.kt 0.00% ❌
varint/src/commonMain/kotlin/io/iohk/atala/prism/apollo/varint/VarInt.kt 93.33% ✅
Total Project Coverage 91.00% ✅

@hamada147
refactor: Dependency updates & Code Enhancements
fc0fcaa 
- Remove podspec files as we moved from CocoaPods to SPM
- Update most dependencies
- Commented RSA Keys classes and objects as we no longer support RSA
- Update def files and Gradle script to support all Apple targets
- Update README for each module

Signed-off-by: Ahmed Moussa <[email protected]>
curtis-h
curtis-h reviewed Sep 20, 2023
View reviewed changes
...ymmetric-encryption/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAKeyPair.kt
@@ -1,5 +1,5 @@
package io.iohk.atala.prism.apollo.utils

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comment out the class, instead of removing it? we've got source control if we ever want it back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will remove all of them 👍

@hamada147 hamada147 marked this pull request as draft September 28, 2023 13:28
@goncalo-frade-iohk
Copy link
Contributor

goncalo-frade-iohk commented Nov 20, 2023 •
edited
Loading

We can probably close this PR @hamada147 . Its very outdated already

@hamada147
Copy link
Contributor Author

Agreed 👍

@hamada147 hamada147 closed this Nov 20, 2023
@hamada147 hamada147 deleted the platform-update branch May 31, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtis-h curtis-h curtis-h left review comments

@elribonazo elribonazo Awaiting requested review from elribonazo elribonazo is a code owner

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk goncalo-frade-iohk is a code owner

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK cristianIOHK is a code owner

@petevielhaber petevielhaber Awaiting requested review from petevielhaber petevielhaber will be requested when the pull request is marked ready for review petevielhaber is a code owner

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk yshyn-iohk will be requested when the pull request is marked ready for review yshyn-iohk is a code owner

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk amagyar-iohk will be requested when the pull request is marked ready for review amagyar-iohk is a code owner

Assignees

@hamada147 hamada147

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamada147 @atala-dev @goncalo-frade-iohk @curtis-h