Add path config edit command #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Aug 22, 2023
cmd/config.go
Outdated
| switch key { | ||
| case "client-id": | ||
| configPath.Src.ClientID = value | ||
| configPath.Dst.ClientID = value |
There was a problem hiding this comment.
In general, src client id can be different from dst client id.
The same can be said about connection id, channel id, and port id.
There was a problem hiding this comment.
Add src/dst args
$RLY paths edit $PATH_NAME client-id src clinet-id-src
$RLY paths edit $PATH_NAME client-id dst clinet-id-dst
siburu
reviewed
Aug 22, 2023
cmd/config.go
Outdated
| @@ -23,6 +22,7 @@ func configCmd(ctx *config.Context) *cobra.Command { | |||
| cmd.AddCommand( | |||
| configShowCmd(ctx), | |||
| configInitCmd(), | |||
| configEditCmd(ctx), | |||
There was a problem hiding this comment.
Should you add this feature to the paths subcommand instead of the config subcommand?
There was a problem hiding this comment.
move to the paths subcommand
e39fd4c
siburu
reviewed
Aug 22, 2023
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Aug 23, 2023
siburu
reviewed
Aug 23, 2023
cmd/paths.go
Outdated
| @@ -108,14 +110,76 @@ func pathsAddCmd(ctx *config.Context) *cobra.Command { | |||
| return fileFlag(cmd) | |||
| } | |||
|
|
|||
| func pathsEditCmd(ctx *config.Context) *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "edit [path-name] [key] [src/dst] [value]", | |||
There was a problem hiding this comment.
The following order is more preferable.
- path-name
- src or dst
- key
- value
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Aug 24, 2023
cmd/paths.go
Outdated
| if err := overWriteConfig(ctx, cmd); err != nil { | ||
| return err | ||
| } | ||
| fmt.Println("config file updated") |
There was a problem hiding this comment.
@dongrie
This message is unnecessary and please delete it.
return overWriteConfig(ctx, cmd)
The other part looks perfect. Thanks.
Signed-off-by: Dongri Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add edit command to config commands
example