Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger (ibc-go v7) #92

Merged
merged 47 commits into from
Sep 6, 2023
Merged

Add logger (ibc-go v7) #92

merged 47 commits into from
Sep 6, 2023

Conversation

dongrie
Copy link
Contributor

@dongrie dongrie commented Jul 6, 2023

Add logger(zap)

Messages and information such as transactions can now be viewed when an error occurs.

before

before

after

alter

@dongrie
Add logger
a2cde6f 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix log
bd38968 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
merge
462040b
@dongrie dongrie requested a review from a team as a code owner July 6, 2023 07:50
@dongrie
Fix zap logger
539ab8c 
Signed-off-by: Dongri Jin <[email protected]>
@siburu

This comment was marked as outdated.

Sign in to view
siburu
siburu reviewed Jul 12, 2023
View reviewed changes
cmd/query.go Outdated Show resolved Hide resolved
cmd/query.go Outdated Show resolved Hide resolved
core/channel.go Outdated Show resolved Hide resolved
@dongrie dongrie closed this Jul 19, 2023
@dongrie dongrie force-pushed the add-logger branch 2 times, most recently from 85e3d29 to d0de4f8 Compare July 19, 2023 02:19
@dongrie dongrie reopened this Jul 19, 2023
siburu
siburu reviewed Jul 19, 2023
View reviewed changes
logger/zap.go Outdated Show resolved Hide resolved
@siburu

This comment was marked as resolved.

Sign in to view
@dongrie

This comment was marked as resolved.

Sign in to view
@dongrie dongrie requested a review from siburu July 25, 2023 00:56
@dongrie
Fix log message
b3df4eb 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Add info
88b1fe4 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix parameter
918b1bd 
Signed-off-by: Dongri Jin <[email protected]>
siburu
siburu reviewed Aug 2, 2023
View reviewed changes
logger/zap.go Outdated Show resolved Hide resolved
logger/zap.go Outdated Show resolved Hide resolved
logger/zap.go Outdated Show resolved Hide resolved
logger/zap.go Outdated Show resolved Hide resolved
siburu
siburu reviewed Aug 2, 2023
View reviewed changes
core/connection.go Outdated Show resolved Hide resolved
siburu
siburu reviewed Aug 2, 2023
View reviewed changes
core/connection.go Outdated Show resolved Hide resolved
@dongrie dongrie requested a review from siburu August 3, 2023 10:07
@dongrie dongrie requested a review from siburu August 25, 2023 05:30
@dongrie
Fix cache key
6a1c67d 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix cache key
4314601 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix initLogger
ead4963 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Revert code
d4f9777 
Signed-off-by: Dongri Jin <[email protected]>
siburu
siburu reviewed Aug 28, 2023
View reviewed changes
cmd/root.go Outdated Show resolved Hide resolved
log/slog.go Outdated Show resolved Hide resolved
core/client.go Outdated Show resolved Hide resolved
core/connection.go Outdated Show resolved Hide resolved
core/connection.go Outdated Show resolved Hide resolved
core/config.go Outdated Show resolved Hide resolved
log/slog.go Outdated Show resolved Hide resolved
core/naive-strategy.go Show resolved Hide resolved
core/relayMsgs.go Outdated Show resolved Hide resolved
core/service.go Show resolved Hide resolved
siburu and others added 9 commits August 31, 2023 14:27
@siburu
Merge tag 'v0.4.6' into add-logger
2511434 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
fix Get{Chain,Connection,Channel}Logger interface
10454ab 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
rename GetXxxLogger to GetXxxPairLogger and WithXxx to WithXxxPair
6f16b05 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
fix logging
c588ba6 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
fix logging more
c6dc00c 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
use default config if config.yml not found
5cb6b1b 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
fix typo
4322e31 
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu
fix logging in metrics
dc42584 
Signed-off-by: Masanori Yoshida <[email protected]>
@dongrie
Merge pull request #2 from siburu/add-logger
14cf0c5 
Fix logger
@siburu siburu self-requested a review September 5, 2023 07:57
siburu
siburu reviewed Sep 5, 2023
View reviewed changes
core/channel.go Outdated Show resolved Hide resolved
core/connection.go Outdated Show resolved Hide resolved
@dongrie
Use slog.Group
05ad463 
Signed-off-by: Dongri Jin <[email protected]>
@siburu siburu requested a review from bluele September 6, 2023 01:15
siburu
siburu approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bluele May I ask you to review this as well?

bluele
bluele reviewed Sep 6, 2023
View reviewed changes
log/slog.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Sep 6, 2023
View reviewed changes
core/connection.go
src.ChainID(), src.Path().ClientID, src.Path().ConnectionID,
dst.ChainID(), dst.Path().ClientID, dst.Path().ConnectionID)
logger.Info(
"★ Connection created",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the lack of connection details deliberate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bluele (cc @dongrie )
The logger create by GetConnectionPairLogger() automatically adds information of src/dst connections.

bluele
bluele reviewed Sep 6, 2023
View reviewed changes
core/channel.go Outdated Show resolved Hide resolved
@dongrie
* Use slog.Level.UnmarshalText
46c50e2 
* Fix incorrect log
* Array append Optimization 

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from bluele September 6, 2023 07:43
@dongrie
merge
853d291 
Signed-off-by: Dongri Jin <[email protected]>
bluele
bluele approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 @dongrie @siburu

@siburu siburu merged commit a75f344 into hyperledger-labs:main Sep 6, 2023
6 checks passed
This was referenced Sep 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siburu siburu siburu approved these changes

@bluele bluele bluele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongrie @siburu @bluele