Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-skip] enable prometheus for besu node metrics #2329

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[ci-skip] enable prometheus for besu node metrics #2329

merged 1 commit into from
Aug 7, 2023

Conversation

saikumarbommakanti
Copy link
Contributor

@saikumarbommakanti saikumarbommakanti commented Jul 31, 2023

feat(besu): enable prometheus for besu node metrics

prometheus server deployments for individual organizations

fixes #2290

@saikumarbommakanti saikumarbommakanti changed the title feat(besu): enable prometheus for besu node metrics [besu] enable prometheus for besu node metrics Jul 31, 2023
@saikumarbommakanti saikumarbommakanti changed the title [besu] enable prometheus for besu node metrics [ci-skip] enable prometheus for besu node metrics Jul 31, 2023
Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the PR is ok, please make the requested changes; also it looks nice to have space before and after the value within the curly brackets. when you define a variable and keep it consistent.
eg: var1: {{ var2 }}

prometheus server deployments for individual organizations

fixes #2290

Signed-off-by: saikumarbommakanti <[email protected]>
Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suvajit-sarkar suvajit-sarkar merged commit 7d237a2 into hyperledger-bevel:develop Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants