-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-skip] enable prometheus for besu node metrics #2329
[ci-skip] enable prometheus for besu node metrics #2329
Conversation
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/nested_loop.yaml
Outdated
Show resolved
Hide resolved
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/nested_loop.yaml
Outdated
Show resolved
Hide resolved
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/main.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the PR is ok, please make the requested changes; also it looks nice to have space before and after the value within the curly brackets. when you define a variable and keep it consistent.
eg: var1: {{ var2 }}
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/main.yaml
Outdated
Show resolved
Hide resolved
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/main.yaml
Outdated
Show resolved
Hide resolved
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/nested_loop.yaml
Show resolved
Hide resolved
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/nested_loop.yaml
Outdated
Show resolved
Hide resolved
platforms/hyperledger-besu/configuration/roles/create/prometheus/tasks/main.yaml
Outdated
Show resolved
Hide resolved
prometheus server deployments for individual organizations fixes #2290 Signed-off-by: saikumarbommakanti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat(besu): enable prometheus for besu node metrics
prometheus server deployments for individual organizations
fixes #2290