[ci-skip] utilize the common vault-k8s-mgmt Helm chart #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhkumarkardam
requested review from
sownak,
suvajit-sarkar,
jagpreetsinghsasan,
arsulegai,
weihong-ou and
adityajoshi12
as code owners
saurabhkumarkardam
changed the title
sownak
approved these changes
Jul 14, 2023
… R3-Corda-Ent platforms. This commit implements the following changes: • Updated the shared role setup/vault-kubernetes to support both the Fabric and R3-Corda-Ent platforms. • Implemented vault policy templates, fabric-policy.tpl and r3-corda-ent-policy.tpl, for Fabric and R3-Corda-Ent respectively. • Updated the variables in the shared role setup/vault_kubernetes to ensure compatibility with both the Fabric and R3-Corda-Ent platforms. • Removed the setup/vault-kubernetes from the Corda platform, enabling the use of the shared role setup/vault-kubernetes for the same purpose. • Removed the setup/vault-kubernetes from the Fabric platform, enabling the use of the shared role setup/vault-kubernetes for the same purpose. • Removed the Helm Chart vault_kubernetes from the Fabric platform, enabling the use of the shared Helm Chart vault-k8s-mgmt. These changes enable code reuse and ensure consistency across the Fabric and R3-Corda-Ent platforms, as both now utilize the shared vault-k8s-mgmt Helm chart. fixes #2291 Signed-off-by: saurabhkumarkardam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(shared): utilize shared vault-k8s-mgmt Helm chart for Fabric and R3-Corda-Ent platforms.
fixes #2291