Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-skip] Add README.md files #2305

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

sailajakommineni
Copy link
Contributor

Primary Changes

  1. Add readme files for all charts
  2. Update the values.yaml files
  3. Update the version in chart.yaml file

Modifications in charts
platforms/r3-corda/charts/doorman-tls
platforms/r3-corda/charts/doorman
platforms/r3-corda/charts/generate-certs
platforms/r3-corda/charts/h2-addUser
platforms/r3-corda/charts/h2-password-change
platforms/r3-corda/charts/h2
platforms/r3-corda/charts/mongodb-tls
platforms/r3-corda/charts/mongodb
platforms/r3-corda/charts/nms-tls
platforms/r3-corda/charts/nms
platforms/r3-corda/charts/node-initial-registration
platforms/r3-corda/charts/node
platforms/r3-corda/charts/notary-initial-registration
platforms/r3-corda/charts/notary platforms/r3-corda/charts/storage

Fixes #2285

Copy link
Contributor

@sownak sownak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make the descriptions concise. Like no need to add "on Kubernetes" because helm always deploys on Kubernetes and not anywhere else.

platforms/r3-corda/charts/generate-certs/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/h2-addUser/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/generate-certs/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/h2/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/nms-tls/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/nms/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/notary/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/storage/Chart.yaml Outdated Show resolved Hide resolved
@sailajakommineni sailajakommineni force-pushed the readmecorda branch 4 times, most recently from ea7f91f to f037a38 Compare July 12, 2023 07:42
platforms/r3-corda/charts/node/Chart.yaml Outdated Show resolved Hide resolved
platforms/r3-corda/charts/notary/Chart.yaml Outdated Show resolved Hide resolved
@suvajit-sarkar suvajit-sarkar marked this pull request as ready for review July 17, 2023 04:49
Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes added as comments

Primary Changes
--------------
Add readme files for all charts
Update the values.yaml files
Update the version in chart.yaml file

Modifications in charts
---------------------
platforms/r3-corda/charts/doorman-tls
platforms/r3-corda/charts/doorman
platforms/r3-corda/charts/generate-certs
platforms/r3-corda/charts/h2
platforms/r3-corda/charts/mongodb-tls
platforms/r3-corda/charts/mongodb
platforms/r3-corda/charts/nms-tls
platforms/r3-corda/charts/nms
platforms/r3-corda/charts/node-initial-registration
platforms/r3-corda/charts/node
platforms/r3-corda/charts/notary-initial-registration
platforms/r3-corda/charts/notary

Fixes hyperledger-bevel#2285

Signed-off-by: sailajakommineni <[email protected]>
Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suvajit-sarkar suvajit-sarkar merged commit ea83f22 into hyperledger-bevel:main Jul 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(corda-os): update platform helm charts with README.md
3 participants