-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-skip] Add README.md files #2305
[ci-skip] Add README.md files #2305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make the descriptions concise. Like no need to add "on Kubernetes" because helm always deploys on Kubernetes and not anywhere else.
75fe9ef
to
62f77c1
Compare
4938b12
to
52902e6
Compare
platforms/r3-corda/charts/notary-initial-registration/Chart.yaml
Outdated
Show resolved
Hide resolved
ea7f91f
to
f037a38
Compare
f037a38
to
5a28f80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes added as comments
Primary Changes -------------- Add readme files for all charts Update the values.yaml files Update the version in chart.yaml file Modifications in charts --------------------- platforms/r3-corda/charts/doorman-tls platforms/r3-corda/charts/doorman platforms/r3-corda/charts/generate-certs platforms/r3-corda/charts/h2 platforms/r3-corda/charts/mongodb-tls platforms/r3-corda/charts/mongodb platforms/r3-corda/charts/nms-tls platforms/r3-corda/charts/nms platforms/r3-corda/charts/node-initial-registration platforms/r3-corda/charts/node platforms/r3-corda/charts/notary-initial-registration platforms/r3-corda/charts/notary Fixes hyperledger-bevel#2285 Signed-off-by: sailajakommineni <[email protected]>
5a28f80
to
a55d76f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Primary Changes
Modifications in charts
platforms/r3-corda/charts/doorman-tls
platforms/r3-corda/charts/doorman
platforms/r3-corda/charts/generate-certs
platforms/r3-corda/charts/h2-addUser
platforms/r3-corda/charts/h2-password-change
platforms/r3-corda/charts/h2
platforms/r3-corda/charts/mongodb-tls
platforms/r3-corda/charts/mongodb
platforms/r3-corda/charts/nms-tls
platforms/r3-corda/charts/nms
platforms/r3-corda/charts/node-initial-registration
platforms/r3-corda/charts/node
platforms/r3-corda/charts/notary-initial-registration
platforms/r3-corda/charts/notary platforms/r3-corda/charts/storage
Fixes #2285