fix(cli): Update warp apply to apply changes in single command #4672
+211
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D extends in a single call
🦋 Changeset detectedLatest commit: e4be6d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yorhodes
approved these changes
Oct 11, 2024
Comment on lines
+509
to
+514
| const mergedRouters = mergeAllRouters( | ||
| multiProvider, | ||
| existingConfigs, | ||
| newDeployedContracts, | ||
| warpCoreConfigByChain, | ||
| ); |
There was a problem hiding this comment.
can we just join the newDeployedContracts with the existing deployed and pass that to the update step?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4672 +/- ##
=======================================
Coverage 73.85% 73.85%
=======================================
Files 100 100
Lines 1423 1423
Branches 181 181
=======================================
Hits 1051 1051
Misses 351 351
Partials 21 21
|
xeno097
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a limitation in
warp applysuch that it can only extend or update an existing warp route. This means that for configs with both changes requirewarp applyto be called multiple times. An example is when Renzo deploys to new chain, and it needs to update the existing ISMs.Related issues
Backward compatibility
Yes
Testing
Manual/Unit Tests