docs: improve comment around cloning middleware in examples #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 7, 2024
|
Could you conforms the commit's message to conventional-commits which conventional-changelog bases on, used in this project. |
shikhar
force-pushed
the
examples-clone
branch
from
5f9fd22
to
9156523
Compare
|
updated! |
shikhar
changed the title
I see it is actually used on the client-side, tonic/tonic/src/transport/channel/mod.rs Line 68 in be4e0e7 But I think the reference to tower docs is probably more useful. |
tottoto
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tower does not seem to use the buffer middleware (anymore?) so the existing comment is invalid, but the pattern is still sensible given https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services