fix(http1): send 'connection: close' during graceful shutdown #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably a good idea? Is there any reason this would we bad? |
seanmonstar
force-pushed
the
http1-graceful-sends-conn-close-header
branch
from
36c6a65
to
a16dc2c
Compare
seanmonstar
force-pushed
the
http1-graceful-sends-conn-close-header
branch
4 times, most recently
from
a9f1836
to
8f81801
Compare
seanmonstar
force-pushed
the
http1-graceful-sends-conn-close-header
branch
from
8f81801
to
7845c61
Compare
|
Thanks! I'll be waiting for a new release with this fix:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3720