Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReasonPhrase Polish #3295

Merged
merged 2 commits into from
Aug 24, 2023
Merged

ReasonPhrase Polish #3295

merged 2 commits into from
Aug 24, 2023

Conversation

seanmonstar
Copy link
Member

This removes the from_bytes_unchecked() method, since it's utility seems dubious (we can always add back if it's badly needed). It also makes from_static a const fn.

@seanmonstar
feat(ext): remove ReasonPhrase::from_bytes_unchecked() method
0fee8e1 
BREAKING CHANGE: The `ReasonPhrase::from_bytes_unchecked()` method is
  gone. Use `from_static()` or `TryFrom` to construct one.
@seanmonstar
feat(ext): make ReasonPhrase::from_static a const fn
225a0d1
@seanmonstar seanmonstar added the B-breaking-change Blocked: this is an "API breaking change". label Aug 24, 2023
@seanmonstar seanmonstar added this to the 1.0 milestone Aug 24, 2023
acfoltzer
acfoltzer approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me; we are not currently using this method and, like you say, it can be easily added back if we're missing an anticipated use case

@seanmonstar seanmonstar merged commit d4a61e3 into master Aug 24, 2023
17 checks passed
@seanmonstar seanmonstar deleted the reason-phrase-polish branch August 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acfoltzer acfoltzer acfoltzer approved these changes

Assignees
No one assigned
Labels
B-breaking-change Blocked: this is an "API breaking change".
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmonstar @acfoltzer