Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add local addr getter to server builder #3278

Conversation

tomkarw
Copy link
Contributor

@tomkarw tomkarw commented Jul 26, 2023

Closes #3272.

@seanmonstar
Copy link
Member

It's a simple enough addition, we could do it! Could you add a simple line of docs to the method?

@tomkarw tomkarw force-pushed the feat-add-local-addr-getter-to-server-builder branch 2 times, most recently from 4fc9dc6 to 5668fb9 Compare July 27, 2023 22:23
@seanmonstar
Copy link
Member

You need three slashes for them to become documentation in Rust: /// This is docs.

@tomkarw tomkarw force-pushed the feat-add-local-addr-getter-to-server-builder branch from 5668fb9 to 42d6db7 Compare July 27, 2023 22:26
@tomkarw
Copy link
Contributor Author

tomkarw commented Aug 7, 2023

@seanmonstar Can you approve & merge this?

@seanmonstar seanmonstar merged commit d342c2c into hyperium:0.14.x Aug 7, 2023
19 checks passed
@tomkarw tomkarw deleted the feat-add-local-addr-getter-to-server-builder branch August 8, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants