Fixed array state for symfony/http-foundation >= 6.0 #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozahorulia
force-pushed
the
symfony-http-foundation-6-fix
branch
from
fb6b7cb
to
4f088c0
Compare
|
Please, re-trigger the CI, I just forgot to commit everything from the first attempt. |
|
Hmm, cs-fixer fails, but looks like it comes from master. Should it ignore that? |
|
@stloyd thanks for merging! Is there any ETA on creating a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upgraded my project to symfony 6.4 (particularly the http-foundation component), I've noticed that OAuthUtils started to throw exception if "state" parameter is passed as an array (this is the way we do it in my project atm). According to the http-foundation changelog:
This behavior has been deprecated since v5.1 and removed in 6.0.
I've also added symfony/http-foundation as a direct dependency to the composer.json. I was not sure about it, but it's obvious that this bundle relates on the Request class from the http-foundation, but it wasn't present in composer.json for some reason.