Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tasks] Rename generate property in task specs #930

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanouticelina
Copy link
Contributor

Fixes #923

This PR updates the task specs to rename the generate property to generation_parameters. This change aligns with the discussion in the issue.

Key changes:

  • Renamed generate to generation_parameters in the specs for automatic-speech-recognition, image-to-text, text-to-audio and text-to-speech tasks.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

For other reviewers, Inference API / Inference Endpoints won't support generation_parameters yet but since they already don't support generate, that's not a breaking change 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tasks] Mismatch between input specs and task pipelines expected generation
2 participants