Added CoTracker for download stats #925
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvoursl
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Wauplin
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Looks good! Would be a good occasion to update CoTracker's GitHub README and HF Model Card to showcase how to load the model from the Hugging Face Hub directly. For now it's showcasing
cotracker = torch.hub.load("facebookresearch/co-tracker", "cotracker2").to(device)which doesn't use the HF built-in cache system (though it's pulling from HF from what I can see in the hubconf.py)
If that can help, here is a guide on how to download files using huggingface_hub.
Co-authored-by: Lucain <[email protected]>
Wauplin
reviewed
Sep 30, 2024
| repoName: "CoTracker", | ||
| repoUrl: "https://github.com/facebookresearch/co-tracker", | ||
| filter: false, | ||
| countDownloads: `path_extension:"pt"`, |
There was a problem hiding this comment.
Suggested change
| countDownloads: `path_extension:"pt"`, | |
| countDownloads: `path_extension:"pth"`, |
I just noticed the file extension is not pt but pth in https://huggingface.co/facebook/cotracker/tree/main.
| @@ -715,6 +715,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
| countDownloads: `path:"model_vae_fp16.pt"`, | |||
| snippets: snippets.threedtopia_xl, | |||
| }, | |||
| cotracker: { | |||
There was a problem hiding this comment.
Could you move this entry up in the mapping to keep it consistent with the alphabetical order. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Thanks for the amazing library :)
We are hosting CoTracker model checkpoint here and would like to see the download count. This PR follows this one to enable it.
Hope it's correct way to do it, let me know if any changes are needed or there is a better way to do so.