-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dynamicrafter library #804
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Same comment as in #805 (review), it would be cool to add text-to-video
and image-to-video
tags in models on the Hub. For what I understand DynamiCrafter_512_Interp
is only image-to-video
but other repos can do both? In that case, you can tag them like ali-vilab/i2vgen-xl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Same as #804 (review), it would be cool to have pipeline_tag
in the Hub PRs + get them merged before merging this one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given the open comments 👍
Thanks, I've updated the PRs, have to say that the workflow to do this is pretty hard, not easy to find. It's only documented here how you can manage and update a PR locally which you've opened on the web interface. I'm in contact with the Dynamicrafter author on Slack and will wait for him to merge the PRs above before merging this one. |
Thanks for updating the PRs! This will prove useful! Let us know once it's merged 😃
Arf yes, what I usually do is to use the browser to navigate through the file on the PR ref revision, select the file I want to edit and edit it. In the example below I don't have the Screencast.from.18-07-2024.16.28.54.webm |
Regarding the PRs, I think that https://huggingface.co/Doubiiu/DynamiCrafter_512_Interp/discussions/1/files should be |
This PR adds https://github.com/Doubiiu/DynamiCrafter, a popular text-to-video model, as a library.
To do:
Ensure dynamicrafter PRs are merged on the respective model repos