Feat: 허브 마스터는 허브 링크를 삭제할 수 있다.

hseong3243 · Apr 21, 2024 · abcf1ab · abcf1ab
2 parents 494809e + dc23821
commit abcf1ab
Show file tree

Hide file tree

Showing 16 changed files with 407 additions and 84 deletions.
diff --git a/src/docs/asciidoc/index.adoc b/src/docs/asciidoc/index.adoc
@@ -119,6 +119,16 @@ operation::link-controller-test/delete-link[snippets='http-request,request-heade
 
 operation::link-controller-test/delete-link[snippets='http-response,response-fields']
 
+=== 허브 링크 삭제
+
+==== request
+
+operation::link-controller-test/delete-hub-link[snippets='http-request,request-headers,path-parameters']
+
+==== response
+
+operation::link-controller-test/delete-hub-link[snippets='http-response,response-fields']
+
 == 허브
 
 === 허브 생성

diff --git a/src/main/java/com/seong/shoutlink/domain/hub/Hub.java b/src/main/java/com/seong/shoutlink/domain/hub/Hub.java
@@ -56,8 +56,8 @@ private String validateDescription(String description) {
         return description;
     }
 
-    public void checkMasterAuthority(Long memberId) {
-        if(Objects.equals(masterId, memberId)) {
+    public void checkMasterAuthority(Member member) {
+        if(Objects.equals(masterId, member.getMemberId())) {
             return;
         }
         throw new ShoutLinkException("권한이 없습니다.", ErrorCode.UNAUTHORIZED);

diff --git a/src/main/java/com/seong/shoutlink/domain/link/controller/LinkController.java b/src/main/java/com/seong/shoutlink/domain/link/controller/LinkController.java
@@ -7,6 +7,7 @@
 import com.seong.shoutlink.domain.link.service.LinkUseCase;
 import com.seong.shoutlink.domain.link.service.request.CreateHubLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.CreateLinkCommand;
+import com.seong.shoutlink.domain.link.service.request.DeleteHubLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.DeleteLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.FindHubLinksCommand;
 import com.seong.shoutlink.domain.link.service.request.FindLinksCommand;
@@ -94,4 +95,14 @@ public ResponseEntity<DeleteLinkResponse> deleteLink(
             new DeleteLinkCommand(memberId, linkId));
         return ResponseEntity.ok(deleteLinkResponse);
     }
+
+    @DeleteMapping("/hubs/{hubId}/links/{linkId}")
+    public ResponseEntity<DeleteLinkResponse> deleteHubLink(
+        @LoginUser Long memberId,
+        @PathVariable("hubId") Long hubId,
+        @PathVariable("linkId") Long linkId) {
+        DeleteLinkResponse response = linkUseCase.deleteHubLink(
+            new DeleteHubLinkCommand(linkId, memberId, hubId));
+        return ResponseEntity.ok(response);
+    }
 }
diff --git a/src/main/java/com/seong/shoutlink/domain/link/repository/LinkJpaRepository.java b/src/main/java/com/seong/shoutlink/domain/link/repository/LinkJpaRepository.java
@@ -26,4 +26,9 @@ public interface LinkJpaRepository extends JpaRepository<LinkEntity, Long> {
         + "join MemberLinkBundleEntity lb on l.linkBundleId = lb.linkBundleId "
         + "where l.linkId = :linkId and lb.memberId = :memberId")
     Optional<LinkEntity> findByIdAndMemberId(@Param("linkId") Long linkId, @Param("memberId") Long memberId);
+
+    @Query("select l from LinkEntity l "
+        + "join HubLinkBundleEntity lb on l.linkBundleId = lb.linkBundleId "
+        + "where l.linkId = :linkId and lb.hubId = :hubId")
+    Optional<LinkEntity> findByIdAndHubId(@Param("linkId") Long linkId, @Param("hubId") Long hubId);
 }
diff --git a/src/main/java/com/seong/shoutlink/domain/link/repository/LinkRepositoryImpl.java b/src/main/java/com/seong/shoutlink/domain/link/repository/LinkRepositoryImpl.java
@@ -1,6 +1,7 @@
 package com.seong.shoutlink.domain.link.repository;
 
 import com.seong.shoutlink.domain.domain.Domain;
+import com.seong.shoutlink.domain.hub.Hub;
 import com.seong.shoutlink.domain.link.Link;
 import com.seong.shoutlink.domain.link.LinkWithLinkBundle;
 import com.seong.shoutlink.domain.link.service.LinkRepository;
@@ -76,6 +77,12 @@ public Optional<Link> findMemberLink(Long linkId, Member member) {
             .map(LinkEntity::toDomain);
     }
 
+    @Override
+    public Optional<Link> findHubLink(Long linkId, Hub hub) {
+        return linkJpaRepository.findByIdAndHubId(linkId, hub.getHubId())
+            .map(LinkEntity::toDomain);
+    }
+
     @Override
     public void delete(Link link) {
         linkJpaRepository.deleteById(link.getLinkId());

diff --git a/src/main/java/com/seong/shoutlink/domain/link/service/LinkRepository.java b/src/main/java/com/seong/shoutlink/domain/link/service/LinkRepository.java
@@ -1,6 +1,7 @@
 package com.seong.shoutlink.domain.link.service;
 
 import com.seong.shoutlink.domain.domain.Domain;
+import com.seong.shoutlink.domain.hub.Hub;
 import com.seong.shoutlink.domain.link.Link;
 import com.seong.shoutlink.domain.link.LinkWithLinkBundle;
 import com.seong.shoutlink.domain.link.service.result.LinkPaginationResult;
@@ -23,5 +24,7 @@ public interface LinkRepository {
 
     Optional<Link> findMemberLink(Long linkId, Member member);
 
+    Optional<Link> findHubLink(Long linkId, Hub hub);
+
     void delete(Link link);
 }
diff --git a/src/main/java/com/seong/shoutlink/domain/link/service/LinkService.java b/src/main/java/com/seong/shoutlink/domain/link/service/LinkService.java
@@ -12,6 +12,7 @@
 import com.seong.shoutlink.domain.link.service.event.CreateMemberLinkEvent;
 import com.seong.shoutlink.domain.link.service.request.CreateHubLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.CreateLinkCommand;
+import com.seong.shoutlink.domain.link.service.request.DeleteHubLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.DeleteLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.FindHubLinksCommand;
 import com.seong.shoutlink.domain.link.service.request.FindLinksCommand;
@@ -80,7 +81,8 @@ private Member getMember(Long memberId) {
     @Transactional
     public CreateHubLinkResponse createHubLink(CreateHubLinkCommand command) {
         Hub hub = getHub(command.hubId());
-        hub.checkMasterAuthority(command.memberId());
+        Member member = getMember(command.memberId());
+        hub.checkMasterAuthority(member);
 
         LinkBundle hubLinkBundle = getHubLinkBundle(command.linkBundleId(), hub);
         Link link = new Link(command.url(), command.description());
@@ -106,6 +108,7 @@ public FindLinksResponse findHubLinks(FindHubLinksCommand command) {
     }
 
     @Override
+    @Transactional
     public DeleteLinkResponse deleteLink(DeleteLinkCommand command) {
         Member member = getMember(command.memberId());
         Link link = linkRepository.findMemberLink(command.linkId(), member)
@@ -114,6 +117,19 @@ public DeleteLinkResponse deleteLink(DeleteLinkCommand command) {
         return new DeleteLinkResponse(link.getLinkId());
     }
 
+    @Override
+    @Transactional
+    public DeleteLinkResponse deleteHubLink(DeleteHubLinkCommand command) {
+        Hub hub = getHub(command.hubId());
+        Member member = getMember(command.memberId());
+        hub.checkMasterAuthority(member);
+        Link link = linkRepository.findHubLink(command.linkId(), hub)
+            .orElseThrow(() -> new ShoutLinkException("존재하지 않는 링크입니다.", ErrorCode.NOT_FOUND));
+        linkRepository.delete(link);
+        return new DeleteLinkResponse(link.getLinkId());
+    }
+
+
     private void checkAuthenticated(@Nullable Long nullableMemberId) {
         if(Objects.isNull(nullableMemberId)) {
             throw new ShoutLinkException("인증되지 않은 사용자입니다.", ErrorCode.UNAUTHENTICATED);

diff --git a/src/main/java/com/seong/shoutlink/domain/link/service/LinkUseCase.java b/src/main/java/com/seong/shoutlink/domain/link/service/LinkUseCase.java
@@ -2,6 +2,7 @@
 
 import com.seong.shoutlink.domain.link.service.request.CreateHubLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.CreateLinkCommand;
+import com.seong.shoutlink.domain.link.service.request.DeleteHubLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.DeleteLinkCommand;
 import com.seong.shoutlink.domain.link.service.request.FindHubLinksCommand;
 import com.seong.shoutlink.domain.link.service.request.FindLinksCommand;
@@ -21,4 +22,6 @@ public interface LinkUseCase {
     FindLinksResponse findHubLinks(FindHubLinksCommand command);
 
     DeleteLinkResponse deleteLink(DeleteLinkCommand command);
+
+    DeleteLinkResponse deleteHubLink(DeleteHubLinkCommand command);
 }
diff --git a/src/main/java/com/seong/shoutlink/domain/link/service/request/DeleteHubLinkCommand.java b/src/main/java/com/seong/shoutlink/domain/link/service/request/DeleteHubLinkCommand.java
@@ -0,0 +1,5 @@
+package com.seong.shoutlink.domain.link.service.request;
+
+public record DeleteHubLinkCommand(Long linkId, Long memberId, Long hubId) {
+
+}
diff --git a/src/main/java/com/seong/shoutlink/domain/linkbundle/service/LinkBundleService.java b/src/main/java/com/seong/shoutlink/domain/linkbundle/service/LinkBundleService.java
@@ -63,7 +63,8 @@ private Member getMember(Long memberId) {
     @Transactional
     public CreateLinkBundleResponse createHubLinkBundle(CreateHubLinkBundleCommand command) {
         Hub hub = getHub(command.hubId());
-        hub.checkMasterAuthority(command.memberId());
+        Member member = getMember(command.memberId());
+        hub.checkMasterAuthority(member);
         LinkBundle linkBundle = new LinkBundle(
             command.description(),
             command.isDefault());