Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue1:miniMax feature: Added to conftest.py elseif edge and in #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
from webdriver_manager.chrome import ChromeDriverManager
from webdriver_manager.core.utils import ChromeType

from selenium.webdriver.edge.service import Service as EdgeService
from webdriver_manager.microsoft import EdgeChromiumDriverManager

from main import Constants


Expand Down Expand Up @@ -55,6 +58,8 @@ def web_driver(config) -> WebDriver:
driver = webdriver.Chrome(service=ChromeService(ChromeDriverManager().install()))
elif config['browser'] == 'chromium':
driver = webdriver.Chrome(service=ChromiumService(ChromeDriverManager(chrome_type=ChromeType.CHROMIUM).install()))
elif config['browser'] == 'edge':
driver = webdriver.Edge(service=EdgeService(EdgeChromiumDriverManager().install()))
else:
raise Exception(f'"{config["browser"]}" is not a supported browser')
driver.maximize_window()
Expand Down
2 changes: 1 addition & 1 deletion tests/config.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"browser": "chrome",
"browser": "edge",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about that?

Copy link
Member Author

@miniMax18 miniMax18 Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, This is basis mode. Simply feature to launch by pytest on edge browser

"selenium_grid": "false",
"selenium_grid_url": "testurl.com",
"wait_time": 10
Expand Down