feat: add max_traversed_entries option #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At my work, we have a huge monorepo with a directory with over 70k entries. This plugin, being synchronous, was blocking Neovim for tens of seconds. This option should be universally useful to just time-box any search done by this plugin. I don't think it makes sense to leave this search unbounded as people expect interactivity from Neovim. Perhaps, some change of API will make it possible to make search more optimal (e.g., a batch fetch), but even than a limit to how many entries Neovim has to process is relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At my work, we have a huge monorepo with a directory with over 70k entries. This plugin, being synchronous, was blocking Neovim for tens of seconds.
This option should be universally useful to just time-box any search done by this plugin. I don't think it makes sense to leave this search unbounded as people expect interactivity from Neovim.
Perhaps, some change of API will make it possible to make search more optimal (e.g., a batch fetch), but even than a limit to how many entries Neovim has to process is relevant.