Css day 31 #35
Css day 31 #35
Conversation
| </ul> | ||
| <nav> | ||
| <div className="NavBar"> | ||
| <ul className="NavBar__ul"> |
There was a problem hiding this comment.
I personally don't like class names that start with capital letter, navbar or nav-bar fits better here IMO.
There is no reason to add element name to its class name. I would go with NavBar__list and Navbar__item, there is also no need to add such deep nesting with the name.
There was a problem hiding this comment.
Thank you very much for the reviews
There was a problem hiding this comment.
How deep nesting should be, two or three?
There was a problem hiding this comment.
I would say one level of "elements" in the "block".
In css you can select items by element, no need for tons of classes, for example .navbar__list a
| </li> | ||
| </ul> | ||
| </div> | ||
| <div className="NavBarNarrow"> |
There was a problem hiding this comment.
...Narrow sounds like a modificator to me, probably NavBar--narrow would be better
src/styles/cards-list.scss
Outdated
| flex-wrap: wrap; | ||
| justify-content: flex-start; | ||
| margin: auto; | ||
| padding: 0px 40px; |
There was a problem hiding this comment.
0 is sufficient, no need to add px here
|
|
||
| } | ||
|
|
||
| @media (min-width: 601px) { |
There was a problem hiding this comment.
There is no need to add 2 media queries here, standard approach is mobile-first so you add styles that will be applied normally and then modify them with query filter withmin-width: 601px
https://trello.com/c/B761DdST