GToolkit - Add as Supported Platform

[seandenigris]

• first pass on GToolkit - Add as Platform #544 that downloads GT, loads a project, and runs its tests
• several hardcoded values
• needs cleaning

[seandenigris]

Can someone resend me an invite to the repo? I accepted but it had already expired. Also, I tested this locally, but would someone more familiar with StCI internals have a look and see if it all makes sense? cc/ @fniephaus @girba

[fniephaus]

Can someone resend me an invite to the repo?

What kind of access do you need to the repo and what for?

I tested this locally, but would someone more familiar with StCI internals have a look and see if it all makes sense?

Seems ok so far. There's no point in running the tests though because you didn't add a GToolkit job to the build matrix. Can you do that please?

[seandenigris]

What kind of access do you need to the repo and what for?

Ha ha, don't know. Someone (I think you) had sent me an invitation which expired, so I thought maybe that was important, especially when I noticed I could not trigger CI on my PR without access. Since unfortunately it looks like I will be the GT support maintainer, whatever access level you think would be appropriate for that role, if any.

Seems ok so far. There's no point in running the tests though because you didn't add a GToolkit job to the build matrix. Can you do that please?

Sure, Any guidance on how to do that?

[gcotelli]

What kind of access do you need to the repo and what for?

Ha ha, don't know. Someone (I think you) had sent me an invitation which expired, so I thought maybe that was important, especially when I noticed I could not trigger CI on my PR without access. Since unfortunately it looks like I will be the GT support maintainer, whatever access level you think would be appropriate for that role, if any.

Seems ok so far. There's no point in running the tests though because you didn't add a GToolkit job to the build matrix. Can you do that please?

Sure, Any guidance on how to do that?

Edit .github/workflows/main.yml in your branch and add the GToolkit variants to the build matrix.

[seandenigris]

Edit .github/workflows/main.yml in your branch and add the GToolkit variants to the build matrix.

Okay, done

[fniephaus]

Since unfortunately it looks like I will be the GT support maintainer, whatever access level you think would be appropriate for that role, if any.

It's unfortunate you think this is unfortunate. 😉 Once you've contributed a PR, the tests will run automatically for your PRs and you can always run the tests in your fork. So for the time being, I don't see why you'd need any additional permissions, unless you want to maintain more than the GT integration. 😅

[fniephaus]

I just triggered the builds for this PR and then this happens. 🤷

[seandenigris]

It's unfortunate you think this is unfortunate. 😉

Ha ha just being dramatic. No big deal

Once you've contributed a PR, the tests will run automatically for your PRs and you can always run the tests in your fork.

Aha. Okay. Running the test for my PR was the issue, so that’s good news.

So for the time being, I don't see why you'd need any additional permissions, unless you want to maintain more than the GT integration. 😅

Sounds like we’re all good then

[seandenigris]

I just triggered the builds for this PR and then this happens. 🤷

Looks like it’s resolved

[fniephaus]

Since you complained about writing some Bash, I took care of the JavaScript part for all of this:
hpi-swa/setup-smalltalkCI@4d1933c.

Nonetheless, there is a test failure:

SmalltalkCIPharoTest
 ✗ #testPromptToProceed (5506ms)
SubclassResponsibility: RustWindowingWorldRenderer class had the subclass responsibility to implement #isApplicableFor:
RustWindowingWorldRenderer class(Object)>>subclassResponsibility
RustWindowingWorldRenderer class(AbstractWorldRenderer class)>>isApplicableFor:
[ :aClass | aClass isApplicableFor: aWorld ] in AbstractWorldRenderer class>>detectCorrectOneForWorld:
[ :each | 
			(aBlock value: each)
				ifTrue: [ ^ foundBlock cull: each ] ] in OrderedCollection(Collection)>>detect:ifFound:ifNone:
OrderedCollection>>do:
OrderedCollection(Collection)>>detect:ifFound:ifNone:
OrderedCollection(Collection)>>detect:ifFound:
AbstractWorldRenderer class>>detectCorrectOneForWorld:
MorphicUIManager>>activate
UIManager class>>default:
SmalltalkCIPharoTest>>testPromptToProceed ...default: MorphicUIManager new
SCICoverageWrapper>>run:with:in:
SmalltalkCIPharoTest(Object)>>perform:
SmalltalkCIPharoTest(TestCase)>>performTest

https://github.com/hpi-swa/smalltalkCI/actions/runs/4321917736/jobs/7543790478#step:4:1352

[seandenigris]

Since you complained about writing some Bash, I took care of the JavaScript part for all of this

Ha ha thanks. See sometimes complaining works

Nonetheless, there is a test failure:

I’m not sure how to fix that. I reported it on GT’s Discord. Hopefully someone at feenk will weigh in

[seandenigris]

Nonetheless, there is a test failure:
SmalltalkCIPharoTest
✗ #testPromptToProceed (5506ms)

Per @chisandrei on GT Discord:

Right at moment we are doing a larger pass on the graphical stack for linux. Not sure if this error is related, but should be easier to debug after that pass is done

The issue for the above mentioned graphical stack pass is feenkcom/gtoolkit#3107

In the meantime, I can have a look. Any tips for how I might easily reproduce this locally?

[seandenigris]

feenkcom/gtoolkit#3107 is closed. @fniephaus can you rerun the CI/tests? Perhaps we’ll get a better result!

[fniephaus]

Any tips for how I might easily reproduce this locally?

Clone the smalltalkCI repo and run what runs on GitHub Actions:

smalltalkCI/.github/workflows/main.yml

Line 80 in 5642d38

bin/smalltalkci -s ${{ matrix.smalltalk }} --self-test

Add --headfull for access to the UI.

can you rerun the CI/tests? Perhaps we’ll get a better result!

Sure, but unfortunately still failing.

[fniephaus]

I wouldn't mind skipping the test when running on GToolkit.

[fniephaus]

I've disabled the test on GToolkit and renamed GToolkit-release to GToolkit64-release. If you like, we can merge this now.

[seandenigris]

Thanks! Yes I’d like to start using this and we can evolve as needed