Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbp 951 implement automated moodle chart deployment via ansible #99

Conversation

marhode
Copy link

@marhode marhode commented Sep 18, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@marhode marhode requested review from maxi418 and a team September 18, 2024 15:00
@marhode marhode self-assigned this Sep 18, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -34,6 +35,8 @@ jobs:
echo "registries=dockerhub" >> $GITHUB_OUTPUT
elif [[ "${{ steps.nameTag.outputs.tag }}" == 'cron-tools' ]]; then
echo "registries=dockerhub,quay.io" >> $GITHUB_OUTPUT
elif [[ "${{ steps.nameTag.outputs.tag }}" == 'moodle-tools' ]]; then
echo "registries=ghcr.io" >> $GITHUB_OUTPUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't moodle-tools also get published to Dockerhub and Quay?

FROM ubuntu:22.04

ARG DEBIAN_FRONTEND=noninteractive
ENV TZ=Europe/Berlin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is not only in this Dockerfile, i think we once talked in a Reffinement about which system time we want to use, and did not we say that we want to use UTC?

@marhode marhode closed this Sep 20, 2024
@marhode marhode deleted the DBP-951-Implement-automated-moodle-chart-deployment-via-ansible branch September 20, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants