Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: appease codeql warning #270

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

codeboten
Copy link
Contributor

Which problem is this PR solving?

The following warning is triggered by CodeQL scanning: "As of Go 1.21, toolchain versions must use the 1.N.P syntax." as per https://go.dev/doc/toolchain#version

Short description of the changes

  • updated go.mod file to include the patch version as well. used .0 to remain compatible with all versions of go 1.21

As of Go 1.21, toolchain versions must use the 1.N.P syntax.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team as a code owner July 25, 2024 15:50
@JamieDanielson
Copy link
Contributor

JamieDanielson commented Jul 25, 2024

actually is there a later patch that we want here?

EDIT: just saw your note "used .0 to remain compatible with all versions of go 1.21". 🚀

@codeboten codeboten merged commit e1b8b6d into main Jul 25, 2024
6 checks passed
@codeboten codeboten deleted the codeboten/update-build-version branch July 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants