Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify socket timeout #967

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Simplify socket timeout #967

merged 1 commit into from
Oct 7, 2024

Conversation

emontnemery
Copy link
Collaborator

Simplify socket read timeout:

  • Remove the non-blocking timeout value, it's no longer needed since support for custom event loop is removed
  • Simplify the timeout, there's no need to pass the value around

This is a fixed version of #877, that PR removed the timeout completely which prevented calling the HeartbeatController often enough.

@joostlek joostlek merged commit 26d2328 into master Oct 7, 2024
1 check passed
@joostlek joostlek deleted the remove_socket_select_timeout_2 branch October 7, 2024 08:48
@emontnemery emontnemery mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emontnemery @joostlek